Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: components/arc/arc_service_manager.h

Issue 2581953002: Introduce ArcServiceManager::OnShutdown(). (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/arc_service_manager.h
diff --git a/components/arc/arc_service_manager.h b/components/arc/arc_service_manager.h
index cc3dbf6e083726af990d8756bf09ae7d5c938e98..091fc9d96a8a3d3669f1dce5c5ed19d0dd000946 100644
--- a/components/arc/arc_service_manager.h
+++ b/components/arc/arc_service_manager.h
@@ -28,6 +28,11 @@ class ArcServiceManager {
public:
class Observer {
public:
+ // Called when ArcServiceManager is being shutdown. Observer implementation
Daniel Erat 2016/12/16 16:05:44 nit: s/shutdown/shut down/ ("shut down" is the ver
hidehiko 2016/12/16 17:14:17 Good to know about verb v.s. noun. Thank you. Fixe
+ // should call clean up ARC related stuff here. One of the typical
Daniel Erat 2016/12/16 16:05:44 nit: delete "call"?
hidehiko 2016/12/16 17:14:17 Done.
+ // use case is calling ArcServiceManager::RemoveObserver().
Daniel Erat 2016/12/16 16:05:44 nit: s/case/cases/
hidehiko 2016/12/16 17:14:17 Done.
+ virtual void OnArcShutdown() = 0;
+
// Called when intent filters are added or removed.
virtual void OnIntentFiltersUpdated() = 0;

Powered by Google App Engine
This is Rietveld 408576698