Introduce ArcServiceManager::OnShutdown().

components/arc/arc_service_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_ARC_SERVICE_MANAGER_H_
 #define COMPONENTS_ARC_ARC_SERVICE_MANAGER_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 10 matching lines @@
 class ArcBridgeService;
 class ArcIntentHelperObserver;
 class ArcService;
 
 // Manages creation and destruction of services that communicate with the ARC
 // instance via the ArcBridgeService.
 class ArcServiceManager {
  public:
   class Observer {
    public:
+    // Called when ArcServiceManager is being shutdown. Observer implementation

[Daniel Erat, 2016/12/16 16:05:44]

nit: s/shutdown/shut down/ ("shut down" is the verb, "shutdown" is the noun)

[hidehiko, 2016/12/16 17:14:17]

Good to know about verb v.s. noun. Thank you. Fixed.

+    // should call clean up ARC related stuff here. One of the typical

[Daniel Erat, 2016/12/16 16:05:44]

nit: delete "call"?

[hidehiko, 2016/12/16 17:14:17]

Done.

+    // use case is calling ArcServiceManager::RemoveObserver().

[Daniel Erat, 2016/12/16 16:05:44]

nit: s/case/cases/

[hidehiko, 2016/12/16 17:14:17]

Done.

+    virtual void OnArcShutdown() = 0;
+
     // Called when intent filters are added or removed.
     virtual void OnIntentFiltersUpdated() = 0;
 
    protected:
     virtual ~Observer() = default;
   };
 
   explicit ArcServiceManager(
       scoped_refptr<base::TaskRunner> blocking_task_runner);
   ~ArcServiceManager();
 
   // |arc_bridge_service| can only be accessed on the thread that this
   // class was created on.
   ArcBridgeService* arc_bridge_service();
 
   // Adds a service to the managed services list.
   void AddService(std::unique_ptr<ArcService> service);
 
   // Gets the global instance of the ARC Service Manager. This can only be
   // called on the thread that this class was created on.
   static ArcServiceManager* Get();
 
   // Returns if the ARC Service Manager instance exists.
   // DO NOT CALL THIS. This function is a dirty workaround for properly shutting
   // down chrome/browser/chromeos/extensions/file_manager/event_router.cc, and
   // will likely be removed in the future.
   static bool IsInitialized();

[Shuhei Takahashi, 2016/12/16 13:36:13]

Please remove this declaration.

[hidehiko, 2016/12/16 17:14:17]

Good catch. Done.

 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // Called to shut down all ARC services.
   void Shutdown();
 
   scoped_refptr<base::TaskRunner> blocking_task_runner() const {
     return blocking_task_runner_;
   }
@@ skipping 31 matching lines @@
   scoped_refptr<LocalActivityResolver> activity_resolver_;
 
   base::ObserverList<Observer> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcServiceManager);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_ARC_SERVICE_MANAGER_H_