Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2581943003: Move WebMouseWheelEvent into its own header file. (Closed)

Created:
4 years ago by dtapuska
Modified:
4 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, tdresser+watch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, einbinder+watch-test-runner_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebMouseWheelEvent into its own header file. No changes other than modifying includes and appropriately forward declaring the class. BUG=625684 TBR=dcheng@chromium.org, jochen@chromium.org Committed: https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d Cr-Commit-Position: refs/heads/master@{#439579}

Patch Set 1 #

Patch Set 2 : Fix android, mac and windows build failures #

Patch Set 3 : Fix mac #

Patch Set 4 : Fix mac #

Patch Set 5 : Fix mac unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -64 lines) Patch
M chrome/browser/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_unit_test.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/event_sender.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_rails_filter_mac.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_emulator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_android.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_mac.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/overscroll_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/input/event_with_latency_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/input/gesture_event_stream_validator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/input/input_event_stream_validator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/input/input_param_traits_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/input/synthetic_web_input_event_builders.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/input/render_widget_input_handler.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/pepper/event_conversion.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 1 2 1 chunk +0 lines, -59 lines 0 comments Download
A third_party/WebKit/public/platform/WebMouseWheelEvent.h View 1 chunk +76 lines, -0 lines 0 comments Download
M ui/events/blink/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/blink_event_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_scroll_elasticity_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/web_input_event.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/web_input_event_builders_win.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/web_input_event_traits.h View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/events/blink/web_input_event_traits.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/blink/web_input_event_traits_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (28 generated)
dtapuska
Rick can you look at this simple moving stuff around
4 years ago (2016-12-16 21:31:15 UTC) #11
Rick Byers
LGTM
4 years ago (2016-12-16 22:01:08 UTC) #13
dtapuska
4 years ago (2016-12-19 14:13:09 UTC) #19
dtapuska
On 2016/12/19 14:13:09, dtapuska wrote: TBRing jochen@, dcheng@: This is a simple header file addition. ...
4 years ago (2016-12-19 21:39:22 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581943003/80001
4 years ago (2016-12-19 21:40:19 UTC) #30
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-19 21:46:52 UTC) #33
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/234bb451a006c60823f0ade952cde5232683cd2d Cr-Commit-Position: refs/heads/master@{#439579}
4 years ago (2016-12-19 21:50:07 UTC) #35
dcheng
4 years ago (2016-12-20 09:06:15 UTC) #36
Message was sent while issue was closed.
content/common/input/input_param_traits_unittest.cc lgtm (i think that's the
only file I'm needed as owner)

Powered by Google App Engine
This is Rietveld 408576698