Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2581923003: Hide find toolbar on entering fullscreen mode (Closed)

Created:
4 years ago by shaktisahu
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide find toolbar on entering fullscreen mode The find toolbar is currently showing on entering fullscreen mode. This CL will fix this. Find toolbar won't be shown back after exiting fullscreen. BUG=672410 Committed: https://crrev.com/83e792fa558e807189f8dabf4a6d7f1c1b4f7b69 Cr-Commit-Position: refs/heads/master@{#439545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
shaktisahu
PTAL
4 years ago (2016-12-17 01:07:13 UTC) #2
gone
Can you upload a video showing the new behavior?
4 years ago (2016-12-19 18:51:49 UTC) #3
shaktisahu
On 2016/12/19 18:51:49, dfalcantara (check my queue) wrote: > Can you upload a video showing ...
4 years ago (2016-12-19 19:10:35 UTC) #4
gone
lgtm
4 years ago (2016-12-19 19:38:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581923003/1
4 years ago (2016-12-19 19:46:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 20:44:26 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-19 20:47:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83e792fa558e807189f8dabf4a6d7f1c1b4f7b69
Cr-Commit-Position: refs/heads/master@{#439545}

Powered by Google App Engine
This is Rietveld 408576698