Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2581873003: Respond to Connector::Connect when a native service binary fails to launch (Closed)

Created:
4 years ago by Ken Rockot(use gerrit already)
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Respond to Connector::Connect when a native service binary fails to launch Otherwise we hit a DCHECK in the bindings, because the Connector pipe is still open when we drop the callback. BUG=675019 Committed: https://crrev.com/05cb8ae729c29d4f69626ac0c59b49e2259c5f9f Cr-Commit-Position: refs/heads/master@{#439227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M services/service_manager/service_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Ken Rockot(use gerrit already)
4 years ago (2016-12-16 21:17:23 UTC) #3
Ben Goodger (Google)
lgtm
4 years ago (2016-12-16 21:18:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581873003/1
4 years ago (2016-12-16 21:19:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 23:14:22 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-16 23:19:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05cb8ae729c29d4f69626ac0c59b49e2259c5f9f
Cr-Commit-Position: refs/heads/master@{#439227}

Powered by Google App Engine
This is Rietveld 408576698