Relax the EncryptMetadata check.

Relax the EncryptMetadata check.

BUG=pdfium:644
Review-Url: https://codereview.chromium.org/2581873002
Committed: https://pdfium.googlesource.com/pdfium/+/0fdeeb8175560ce6bbd8bbc14120cc75ea3a2d67

[Tom Sepez, 2016-12-16 01:06:34]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 01:06:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 01:19:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 01:19:06]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-16 19:21:56]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org

[Tom Sepez, 2016-12-16 19:21:56]

npm, for review.

[Tom Sepez, 2016-12-16 19:22:14]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 19:22:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 19:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 19:35:06]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-16 22:41:23]

Description was changed from

==========
Relax the EncryptMetadata check.

BUG=pdfium:644
==========

to

==========
Relax the EncryptMetadata check.

BUG=pdfium:644
==========

[Tom Sepez, 2016-12-16 22:41:23]

tsepez@chromium.org changed reviewers:
+ weili@chromium.org

[Tom Sepez, 2016-12-16 22:41:53]

+wei, since maybe npm out?

[Wei Li, 2016-12-16 23:45:57]

https://codereview.chromium.org/2581873002/diff/20001/core/fpdfapi/parser/cpd...
File core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp (right):

https://codereview.chromium.org/2581873002/diff/20001/core/fpdfapi/parser/cpd...
core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp:39:
ASSERT_FALSE(OpenDocument("bug_644.pdf", "1234"));
Does no-password case test empty password? Otherwise this is exactly same as
BadPasswordVersion5()

https://codereview.chromium.org/2581873002/diff/20001/core/fpdfapi/parser/cpd...
core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp:46:
TEST_F(CPDFSecurityHandlerEmbeddertest, OnwerPasswordVersion5) {
s/Onwer/Owner

[Tom Sepez, 2016-12-17 00:23:48]

https://codereview.chromium.org/2581873002/diff/20001/core/fpdfapi/parser/cpd...
File core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp (right):

https://codereview.chromium.org/2581873002/diff/20001/core/fpdfapi/parser/cpd...
core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp:39:
ASSERT_FALSE(OpenDocument("bug_644.pdf", "1234"));
On 2016/12/16 23:45:57, Wei Li wrote:
> Does no-password case test empty password? Otherwise this is exactly same as
> BadPasswordVersion5()

Nice catch.

[Tom Sepez, 2016-12-17 00:24:35]

https://codereview.chromium.org/2581873002/diff/20001/core/fpdfapi/parser/cpd...
File core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp (right):

https://codereview.chromium.org/2581873002/diff/20001/core/fpdfapi/parser/cpd...
core/fpdfapi/parser/cpdf_security_handler_embeddertest.cpp:46:
TEST_F(CPDFSecurityHandlerEmbeddertest, OnwerPasswordVersion5) {
On 2016/12/16 23:45:57, Wei Li wrote:
> s/Onwer/Owner

Done.

[Tom Sepez, 2016-12-17 00:25:02]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-17 00:25:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 01:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 01:13:51]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-12-17 01:26:35]

lgtm

[Tom Sepez, 2016-12-19 17:49:37]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-12-19 17:49:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 18:02:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482169777600180,
"parent_rev": "da587fab57602e5e10c058e6e632df513fba0c93", "commit_rev":
"0fdeeb8175560ce6bbd8bbc14120cc75ea3a2d67"}

[commit-bot: I haz the power, 2016-12-19 18:02:12]

Description was changed from

==========
Relax the EncryptMetadata check.

BUG=pdfium:644
==========

to

==========
Relax the EncryptMetadata check.

BUG=pdfium:644

Review-Url: https://codereview.chromium.org/2581873002
Committed:
https://pdfium.googlesource.com/pdfium/+/0fdeeb8175560ce6bbd8bbc14120cc75ea3a...
==========

[commit-bot: I haz the power, 2016-12-19 18:02:13]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/0fdeeb8175560ce6bbd8bbc14120cc75ea3a...