Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2581863002:
Removing SelectionPopupController.updateActionModeVisibility() (Closed)
|
Created:
4 years ago by amaralp Modified:
4 years ago Reviewers:
aelias_OOO_until_Jul13 CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemoving SelectionPopupController.updateActionModeVisibility()
SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary.
This patch refactors code to remove it.
This shouldn't have any behavior changes because
|ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is
being dragged. Likewise when the selection handle dragging stops there shouldn't be
a touch scroll in progress.
Committed: https://crrev.com/f4621371eae2c3df94506248c5453716238de5ac
Cr-Commit-Position: refs/heads/master@{#439062}
Patch Set 1 #
Messages
Total messages: 21 (16 generated)
The CQ bit was checked by amaralp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. ========== to ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This should have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if mDraggingSelection ==========
Description was changed from ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This should have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if mDraggingSelection ========== to ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This should have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise if ==========
Description was changed from ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This should have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise if ========== to ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This should have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. ==========
amaralp@chromium.org changed reviewers: + aelias@chromium.org
Description was changed from ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This should have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. ========== to ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This should have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. ==========
Description was changed from ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This should have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. ========== to ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This should have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. ==========
Description was changed from ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This should have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. ========== to ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This shouldn't have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. ==========
Description was changed from ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This shouldn't have on behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. ========== to ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This shouldn't have any behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. ==========
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by amaralp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481873665238270, "parent_rev":
"9b6a8e011738f6083cd90cbad37a3b1840affe3c", "commit_rev":
"e837300543bff228573c9ccaaf9c7bd7f56fef72"}
Message was sent while issue was closed.
Description was changed from ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This shouldn't have any behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. ========== to ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This shouldn't have any behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. Review-Url: https://codereview.chromium.org/2581863002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This shouldn't have any behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. Review-Url: https://codereview.chromium.org/2581863002 ========== to ========== Removing SelectionPopupController.updateActionModeVisibility() SelectionPopupController.updateActionModeVisibility() is confusing and unnecessary. This patch refactors code to remove it. This shouldn't have any behavior changes because |ContentViewCore.setTouchScrollInProgress()| can't be called if the selection is being dragged. Likewise when the selection handle dragging stops there shouldn't be a touch scroll in progress. Committed: https://crrev.com/f4621371eae2c3df94506248c5453716238de5ac Cr-Commit-Position: refs/heads/master@{#439062} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f4621371eae2c3df94506248c5453716238de5ac Cr-Commit-Position: refs/heads/master@{#439062} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
