Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2581833002:
Fix testCrashSymbols with PlzNavigate. (Closed)
DescriptionFix testCrashSymbols with PlzNavigate.
The test was looking for a specific stack trace in the renderer. With PlzNavigate, the stack trace is different. Use a method name that's common to both.
BUG=674730
Committed: https://crrev.com/4b93a7628e18e3c93cce9e0107bbd5573b1c9248
Cr-Commit-Position: refs/heads/master@{#439119}
Patch Set 1 #Patch Set 2 : try another function name #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jam@chromium.org changed reviewers: + nednguyen@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix testCrashSymbols with PlzNavigate. The test was looking for a specific stack trace in the renderer. With PlzNavigate, the stack trace is different. Use a method name that's common to both. BUG=674730 ========== to ========== Fix testCrashSymbols with PlzNavigate. The test was looking for a specific stack trace in the renderer. With PlzNavigate, the stack trace is different. Use a method name that's common to both. BUG=674730 ==========
nednguyen@google.com changed reviewers: + eyaich@chromium.org
lgtm
lgtm
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481904492185930,
"parent_rev": "fb60accff951f6bc03166bb972f2cfad8f9a8e02", "commit_rev":
"5bce7a1f827a2dbab7416bd9967c867e777439d6"}
Message was sent while issue was closed.
Description was changed from ========== Fix testCrashSymbols with PlzNavigate. The test was looking for a specific stack trace in the renderer. With PlzNavigate, the stack trace is different. Use a method name that's common to both. BUG=674730 ========== to ========== Fix testCrashSymbols with PlzNavigate. The test was looking for a specific stack trace in the renderer. With PlzNavigate, the stack trace is different. Use a method name that's common to both. BUG=674730 Review-Url: https://codereview.chromium.org/2581833002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix testCrashSymbols with PlzNavigate. The test was looking for a specific stack trace in the renderer. With PlzNavigate, the stack trace is different. Use a method name that's common to both. BUG=674730 Review-Url: https://codereview.chromium.org/2581833002 ========== to ========== Fix testCrashSymbols with PlzNavigate. The test was looking for a specific stack trace in the renderer. With PlzNavigate, the stack trace is different. Use a method name that's common to both. BUG=674730 Committed: https://crrev.com/4b93a7628e18e3c93cce9e0107bbd5573b1c9248 Cr-Commit-Position: refs/heads/master@{#439119} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4b93a7628e18e3c93cce9e0107bbd5573b1c9248 Cr-Commit-Position: refs/heads/master@{#439119} |
