Measure WebAudio node constructor usage

Measure WebAudio node constructor usage

Just add "Measure" to every constructible webaudio object so that we
can measure how often the constructors are used.  We already have
metrics for the corresponding factory methods, so this fills the gap
between measuring the past and measuring the future.

No other changes introduced.

BUG=674693
TESTS=none

Committed: https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7
Cr-Commit-Position: refs/heads/master@{#439931}

[Raymond Toy, 2016-12-16 17:11:28]

rtoy@chromium.org changed reviewers:
+ foolip@chromium.org, hongchan@chromium.org

[Raymond Toy, 2016-12-16 17:11:29]

PTAL. foolip@ Is this the right way to measure the usage of the constructors? 
We'd like to see how people are using the API and whether people will start to
favor the constructors over the factory methods.

[foolip, 2016-12-16 22:44:20]

lgtm

Yep, this is the simplest way.

[Raymond Toy, 2016-12-19 17:39:14]

rtoy@chromium.org changed reviewers:
+ haraken@chromium.org

[Raymond Toy, 2016-12-19 17:39:14]

PTAL at histograms.xml

[Raymond Toy, 2016-12-19 17:43:56]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 17:44:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hongchan, 2016-12-19 18:27:04]

lgtm

[commit-bot: I haz the power, 2016-12-19 19:33:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 19:33:17]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-12-20 00:19:53]

histograms LGTM

(I'm now observing a couple of CLs that are going to add "1701" though :-)

[Raymond Toy, 2016-12-20 00:20:54]

Yeah, I saw that.  It's a race!

On Mon, Dec 19, 2016 at 4:19 PM, <haraken@chromium.org> wrote:

> histograms LGTM
>
> (I'm now observing a couple of CLs that are going to add "1701" though :-)
>
>
> https://codereview.chromium.org/2581813002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Raymond Toy, 2016-12-20 00:20:54]

Yeah, I saw that.  It's a race!

On Mon, Dec 19, 2016 at 4:19 PM, <haraken@chromium.org> wrote:

> histograms LGTM
>
> (I'm now observing a couple of CLs that are going to add "1701" though :-)
>
>
> https://codereview.chromium.org/2581813002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Raymond Toy, 2016-12-20 18:20:43]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-12-20 18:20:43]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org,
haraken@chromium.org, hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2581813002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-20 18:21:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 22:01:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:01:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Raymond Toy, 2016-12-20 22:17:03]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 23:47:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482272223057950,
"parent_rev": "df2774125af18bbde831486bbdc510716fcaafa1", "commit_rev":
"43fc7e1a49b625b59ef743a2ad4488eae828718e"}

[commit-bot: I haz the power, 2016-12-20 23:48:10]

Description was changed from

==========
Measure WebAudio node constructor usage

Just add "Measure" to every constructible webaudio object so that we
can measure how often the constructors are used.  We already have
metrics for the corresponding factory methods, so this fills the gap
between measuring the past and measuring the future.

No other changes introduced.

BUG=674693
TESTS=none
==========

to

==========
Measure WebAudio node constructor usage

Just add "Measure" to every constructible webaudio object so that we
can measure how often the constructors are used.  We already have
metrics for the corresponding factory methods, so this fills the gap
between measuring the past and measuring the future.

No other changes introduced.

BUG=674693
TESTS=none

Review-Url: https://codereview.chromium.org/2581813002
==========

[commit-bot: I haz the power, 2016-12-20 23:48:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-20 23:51:57]

Description was changed from

==========
Measure WebAudio node constructor usage

Just add "Measure" to every constructible webaudio object so that we
can measure how often the constructors are used.  We already have
metrics for the corresponding factory methods, so this fills the gap
between measuring the past and measuring the future.

No other changes introduced.

BUG=674693
TESTS=none

Review-Url: https://codereview.chromium.org/2581813002
==========

to

==========
Measure WebAudio node constructor usage

Just add "Measure" to every constructible webaudio object so that we
can measure how often the constructors are used.  We already have
metrics for the corresponding factory methods, so this fills the gap
between measuring the past and measuring the future.

No other changes introduced.

BUG=674693
TESTS=none

Committed: https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7
Cr-Commit-Position: refs/heads/master@{#439931}
==========

[commit-bot: I haz the power, 2016-12-20 23:51:58]

Patchset 4 (id:??) landed as
https://crrev.com/f9a7e96b476a052615c9e7e32ec99d72a8f642d7
Cr-Commit-Position: refs/heads/master@{#439931}