Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2581753002: DevTools: follow-up to crrev.com/2570783006 (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: follow-up to crrev.com/2570783006 Thie crrev.com/2570783006 introduced a non-icon-mask class for toolbarButtonGlyphs, which clashed with masked images. This patch eliminates the clash. BUG=674418, 674425 TBR=dgozman NOTRY=true Committed: https://crrev.com/e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861 Cr-Commit-Position: refs/heads/master@{#438878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
lushnikov
please, take a look
4 years ago (2016-12-15 18:17:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581753002/1
4 years ago (2016-12-15 18:18:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 18:24:12 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-15 18:26:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861
Cr-Commit-Position: refs/heads/master@{#438878}

Powered by Google App Engine
This is Rietveld 408576698