Defer focus handling to the content if it claims to have focus.

Defer focus handling to the content if it claims to have focus.

- Added |CustomNotificationView::OnContentFocused| and
  |CustomNotificationView::OnContentBlured| for handling a focus
  painter.

BUG=661105
TEST=n/a; no behavior change.

Review-Url: https://codereview.chromium.org/2581703003
Cr-Commit-Position: refs/heads/master@{#441645}
Committed: https://chromium.googlesource.com/chromium/src/+/40f710956ce7f40fe60008b5da0c818cf04b49be

[yhanada, 2016-12-16 09:55:59]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 09:56:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 10:39:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 10:39:47]

Dry run: This issue passed the CQ dry run.

[yhanada, 2016-12-16 10:41:37]

yhanada@chromium.org changed reviewers:
+ yoshiki@chromium.org

[yhanada, 2016-12-16 10:41:38]

Hi yoshiki@, PTAL.

[yoshiki, 2017-01-05 07:12:39]

Thanks. LGTM

https://codereview.chromium.org/2581703003/diff/1/ui/message_center/views/cus...
File ui/message_center/views/custom_notification_view.cc (right):

https://codereview.chromium.org/2581703003/diff/1/ui/message_center/views/cus...
ui/message_center/views/custom_notification_view.cc:98: if
(contents_view_->IsFocusable()) {
nit: no braces for one line block.

[yhanada, 2017-01-05 13:12:44]

Thanks for reviewing!

https://codereview.chromium.org/2581703003/diff/1/ui/message_center/views/cus...
File ui/message_center/views/custom_notification_view.cc (right):

https://codereview.chromium.org/2581703003/diff/1/ui/message_center/views/cus...
ui/message_center/views/custom_notification_view.cc:98: if
(contents_view_->IsFocusable()) {
On 2017/01/05 07:12:39, yoshiki wrote:
> nit: no braces for one line block.

Done.

[yhanada, 2017-01-05 13:12:48]

The CQ bit was checked by yhanada@chromium.org

[yhanada, 2017-01-05 13:12:49]

The patchset sent to the CQ was uploaded after l-g-t-m from yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/2581703003/#ps20001
(title: "address the comment")

[commit-bot: I haz the power, 2017-01-05 13:13:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 13:50:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483621968971340,
"parent_rev": "873d4ac7f893b5f84702a5fe5787045e82b1047a", "commit_rev":
"40f710956ce7f40fe60008b5da0c818cf04b49be"}

[commit-bot: I haz the power, 2017-01-05 13:50:42]

Description was changed from

==========
Defer focus handling to the content if it claims to have focus.

- Added |CustomNotificationView::OnContentFocused| and
  |CustomNotificationView::OnContentBlured| for handling a focus
  painter.

BUG=661105
TEST=n/a; no behavior change.
==========

to

==========
Defer focus handling to the content if it claims to have focus.

- Added |CustomNotificationView::OnContentFocused| and
  |CustomNotificationView::OnContentBlured| for handling a focus
  painter.

BUG=661105
TEST=n/a; no behavior change.

Review-Url: https://codereview.chromium.org/2581703003
Cr-Commit-Position: refs/heads/master@{#441645}
Committed:
https://chromium.googlesource.com/chromium/src/+/40f710956ce7f40fe60008b5da0c...
==========

[commit-bot: I haz the power, 2017-01-05 13:50:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/40f710956ce7f40fe60008b5da0c...