Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 2581643002: Define a new policy to disable clearing the browsing history from the UI. (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
Reviewers:
pastarmovj
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, tnagel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define a new policy to disable clearing the browsing history from the UI. The pref "history.deleting_enabled" was already present for supervised users, so it was only a matter of wiring it to a new policy. Written by pastarmovj@chromium.org http://crrev.com/2531623002 Improved by dbeam@chromium.org here. BUG=401064 TEST=browser_tests,unit_tests CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/25a07aca63e9157b1d3dafe801d6532a06f665c8 Cr-Commit-Position: refs/heads/master@{#438929}

Patch Set 1 #

Patch Set 2 : less headers #

Messages

Total messages: 15 (11 generated)
pastarmovj
lgtm
4 years ago (2016-12-15 09:09:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581643002/20001
4 years ago (2016-12-15 21:03:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 21:36:52 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 21:39:24 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25a07aca63e9157b1d3dafe801d6532a06f665c8
Cr-Commit-Position: refs/heads/master@{#438929}

Powered by Google App Engine
This is Rietveld 408576698