Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2581633002: [FirstMeaningfulPaint] Do not stop observing layouts before FirstContentfulPaint (Closed)

Created:
4 years ago by Kunihiko Sakamoto
Modified:
4 years ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[FirstMeaningfulPaint] Do not stop observing layouts before FirstContentfulPaint This should mitigate a bug that FirstMeaningfulPaint is reported too soon (or not reported) on some CPU-heavy pages, because network idle is detected while CPU is busy running scripts. BUG=659021, 674228 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/2b891d60b92a6066fa1620794e244ef6e0ce65e2 Cr-Commit-Position: refs/heads/master@{#438791}

Patch Set 1 #

Patch Set 2 : fix&add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp View 1 5 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Kunihiko Sakamoto
4 years ago (2016-12-15 06:54:45 UTC) #6
kouhei (in TOK)
lgtm Fair enough
4 years ago (2016-12-15 07:32:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581633002/20001
4 years ago (2016-12-15 07:50:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 09:26:27 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 09:28:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b891d60b92a6066fa1620794e244ef6e0ce65e2
Cr-Commit-Position: refs/heads/master@{#438791}

Powered by Google App Engine
This is Rietveld 408576698