Do not make objects in optimized code weak if collecting maps is disabled.

Do not make objects in optimized code weak if collecting maps is disabled.

When collecting maps is disabled we do not clear non-live references.

BUG=
R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21044

[ulan, 2014-04-29 12:18:35]

PTAL

[Igor Sheludko, 2014-04-29 12:22:56]

lgtm with a nit:

https://codereview.chromium.org/258163003/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/258163003/diff/1/src/objects-inl.h#newcode4810
src/objects-inl.h:4810: bool Code::IsWeakObjectInOptimizedCode(Object* object) {
Probably it would be better to add
  if (!FLAG_collect_maps ||
      !FLAG_weak_embedded_objects_in_optimized_code) {
    return false;
  }
here and remove these checks from the code below.

[ulan, 2014-04-29 12:26:16]

https://codereview.chromium.org/258163003/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/258163003/diff/1/src/objects-inl.h#newcode4810
src/objects-inl.h:4810: bool Code::IsWeakObjectInOptimizedCode(Object* object) {
On 2014/04/29 12:22:56, Igor Sheludko wrote:
> Probably it would be better to add
>   if (!FLAG_collect_maps ||
>       !FLAG_weak_embedded_objects_in_optimized_code) {
>     return false;
>   }
> here and remove these checks from the code below.

Moved the common check "if (!FLAG_collect_maps) return false" up.

[Igor Sheludko, 2014-04-29 12:31:08]

lgtm

[ulan, 2014-04-29 12:32:44]

Committed patchset #2 manually as r21044 (presubmit successful).