src/objects-inl.h - Issue 258163003: Do not make objects in optimized code weak if collecting maps is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 258163003: Do not make objects in optimized code weak if collecting maps is disabled. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Extract comment check Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 5aea3b5106bc741386914a21207499ff6471d5c3..ddeaede01e01177bf78071b95e88629bb29cb42b 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -4808,9 +4808,9 @@ Object* Code::GetObjectFromEntryAddress(Address location_of_address) {

bool Code::IsWeakObjectInOptimizedCode(Object* object) {

+ if (!FLAG_collect_maps) return false;

if (object->IsMap()) {

return Map::cast(object)->CanTransition() &&

- FLAG_collect_maps &&

FLAG_weak_embedded_maps_in_optimized_code;

}

if (object->IsJSObject() ||

« no previous file with comments | « no previous file | no next file » | no next file with comments »