Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/Source/bindings/scripts/idl_definitions.py

Issue 2581613002: Use real IDL types in unit test stubs. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/idl_definitions.py
diff --git a/third_party/WebKit/Source/bindings/scripts/idl_definitions.py b/third_party/WebKit/Source/bindings/scripts/idl_definitions.py
index 739fa8858b62cfa7ec373e45f01814d0db7f1470..8a79d043ea52c3e4911faa36cd647e9d8839cfe1 100644
--- a/third_party/WebKit/Source/bindings/scripts/idl_definitions.py
+++ b/third_party/WebKit/Source/bindings/scripts/idl_definitions.py
@@ -441,7 +441,13 @@ class IdlException(IdlInterface):
################################################################################
class IdlAttribute(TypedObject):
- def __init__(self, node):
+ def __init__(self, node=None):
+ self.is_read_only = False
+ self.is_static = False
+ self.name = None
+ if not node:
+ return
+
self.is_read_only = bool(node.GetProperty('READONLY'))
peria 2016/12/15 04:57:08 Could you merge these 3 lines with the new lines?
dglazkov 2016/12/15 05:24:24 They are set above, right?
peria 2016/12/15 05:33:40 Yes, on this CL. But my concern is same with bashi
self.is_static = bool(node.GetProperty('STATIC'))
self.name = node.GetName()

Powered by Google App Engine
This is Rietveld 408576698