Use real IDL types in unit test stubs.

third_party/WebKit/Source/bindings/scripts/idl_definitions.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 423 matching lines @@
                 self.operations.append(IdlOperation.from_exception_operation_node(child))
             else:
                 raise ValueError('Unrecognized node class: %s' % child_class)
 
 
 ################################################################################
 # Attributes
 ################################################################################
 
 class IdlAttribute(TypedObject):
-    def __init__(self, node):
+    def __init__(self, node=None):
+        self.is_read_only = False
+        self.is_static = False
+        self.name = None
+        if not node:
+            return
+
         self.is_read_only = bool(node.GetProperty('READONLY'))

[peria, 2016/12/15 04:57:08]

Could you merge these 3 lines with the new lines?

  self.is_read_only = bool(node....) if node else False
  self.is_static = bool(node...) if node else False
  self.name = node.GetName if node else None

I'm afraid setting no default values will cause errors.

[dglazkov, 2016/12/15 05:24:24]

They are set above, right?

[peria, 2016/12/15 05:33:40]

Yes, on this CL.
But my concern is same with bashi-san's comment on #456.
I hope we don't have an early return, if possible.

         self.is_static = bool(node.GetProperty('STATIC'))
         self.name = node.GetName()
         # Defaults, overridden below

[bashi, 2016/12/15 04:51:15]

nit: I think we can remove this comment (it's obvious).

         self.idl_type = None
         self.extended_attributes = {}

[bashi, 2016/12/15 04:51:15]

Can we move these two lines before 'if not node:' line? I think having default
values is good to avoid an AttributeError as code generator assumes that there
will be these attributes.

 
         children = node.GetChildren()

[peria, 2016/12/15 04:57:08]

ditto.
  children = node.GetChildren() if node else []

         for child in children:
             child_class = child.GetClass()
             if child_class == 'Type':
                 self.idl_type = type_node_to_type(child)
             elif child_class == 'ExtAttributes':
                 self.extended_attributes = ext_attributes_node_to_extended_attributes(child)
             else:
                 raise ValueError('Unrecognized node class: %s' % child_class)
 
     def accept(self, visitor):
@@ skipping 648 matching lines @@
         self.visit_typed_object(argument)
 
     def visit_iterable(self, iterable):
         self.visit_typed_object(iterable)
 
     def visit_maplike(self, maplike):
         self.visit_typed_object(maplike)
 
     def visit_setlike(self, setlike):
         self.visit_typed_object(setlike)