Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2581603003: Media: add metrics for orientation lock when video goes fullscreen. (Closed)

Created:
4 years ago by mlamouri (slow - plz ping)
Modified:
4 years ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media: add metrics for orientation lock when video goes fullscreen. This is recording how often the metadata are already available/needed and the result of the lock attempt. BUG=670455 R=asvitkine@chromium.org, zqzhang@chromium.org Committed: https://crrev.com/47fec97432e9433423940dc69fd06285251ff6fd Cr-Commit-Position: refs/heads/master@{#438958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -2 lines) Patch
M third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegate.cpp View 3 chunks +52 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
mlamouri (slow - plz ping)
PTAL
4 years ago (2016-12-15 17:19:45 UTC) #3
Zhiqiang Zhang (Slow)
lgtm
4 years ago (2016-12-15 21:31:24 UTC) #6
mlamouri (slow - plz ping)
-asvitkine@ +isherman@ PTAL :)
4 years ago (2016-12-15 22:03:06 UTC) #8
Ilya Sherman
Metrics lgtm, thanks.
4 years ago (2016-12-15 22:49:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581603003/1
4 years ago (2016-12-15 23:18:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 23:57:26 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-15 23:59:18 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47fec97432e9433423940dc69fd06285251ff6fd
Cr-Commit-Position: refs/heads/master@{#438958}

Powered by Google App Engine
This is Rietveld 408576698