Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2581563004: Turn on SK_USE_LEGACY_DISTANCE_FIELDS (Closed)

Created:
4 years ago by Joel.Liang
Modified:
4 years ago
Reviewers:
jvanverth1, f(malita)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on SK_USE_LEGACY_DISTANCE_FIELDS Temporary turn the new SDF algorithm feature off. See here for more detail. https://codereview.chromium.org/1643143002 TBR=jvanverth@google.com BUG= Committed: https://crrev.com/cb4eb64a5e0dd2c2bbb53dc7db4c609aa509dcd4 Cr-Commit-Position: refs/heads/master@{#439166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Joel.Liang
Turned on SK_USE_LEGACY_DISTANCE_FIELDS as you suggested here: https://codereview.chromium.org/1643143002#msg134
4 years ago (2016-12-16 05:52:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581563004/1
4 years ago (2016-12-16 05:54:08 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-16 05:54:09 UTC) #5
jvanverth1
lgtm, but needs okay from a Chrome committer before it can be landed.
4 years ago (2016-12-16 14:35:39 UTC) #7
f(malita)
lgtm
4 years ago (2016-12-16 15:52:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581563004/1
4 years ago (2016-12-16 15:53:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 19:25:58 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-16 19:29:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb4eb64a5e0dd2c2bbb53dc7db4c609aa509dcd4
Cr-Commit-Position: refs/heads/master@{#439166}

Powered by Google App Engine
This is Rietveld 408576698