Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2581553004: Store tombstones url, not the actual tombstones, inside test result. (Closed)

Created:
4 years ago by BigBossZhiling
Modified:
4 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store tombstones url, not the actual tombstones, inside test result. Previously we store the actual, huge tombstones inside test result object. Now we record tombstones through logdog and view the tombstones by visiting a url. Thus in test result object, we don't need the actual tombstones anymore. We can just store the lighter tombstones url. BUG=631213 Committed: https://crrev.com/6dd8eaafd2b4b13b712428688d0a7d397102bb29 Cr-Commit-Position: refs/heads/master@{#440199}

Patch Set 1 #

Patch Set 2 : small fixes #

Total comments: 4

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M build/android/pylib/base/base_test_result.py View 2 chunks +5 lines, -5 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 2 1 chunk +10 lines, -5 lines 0 comments Download
M build/android/pylib/results/json_results.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
BigBossZhiling
Changed the content of json results. After this cl, I will change the test results ...
4 years ago (2016-12-15 04:27:27 UTC) #3
jbudorick
https://codereview.chromium.org/2581553004/diff/20001/build/android/pylib/local/device/local_device_gtest_run.py File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/2581553004/diff/20001/build/android/pylib/local/device/local_device_gtest_run.py#newcode418 build/android/pylib/local/device/local_device_gtest_run.py:418: resolved_tombstones = None Should we switch this & the ...
4 years ago (2016-12-15 22:31:35 UTC) #4
BigBossZhiling
https://codereview.chromium.org/2581553004/diff/20001/build/android/pylib/local/device/local_device_gtest_run.py File build/android/pylib/local/device/local_device_gtest_run.py (right): https://codereview.chromium.org/2581553004/diff/20001/build/android/pylib/local/device/local_device_gtest_run.py#newcode418 build/android/pylib/local/device/local_device_gtest_run.py:418: resolved_tombstones = None On 2016/12/15 22:31:35, jbudorick wrote: > ...
4 years ago (2016-12-20 19:34:08 UTC) #5
jbudorick
lgtm
4 years ago (2016-12-21 01:07:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581553004/40001
4 years ago (2016-12-21 18:50:22 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-21 20:19:08 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-21 20:21:12 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6dd8eaafd2b4b13b712428688d0a7d397102bb29
Cr-Commit-Position: refs/heads/master@{#440199}

Powered by Google App Engine
This is Rietveld 408576698