Add infrastructure for a USB device blocklist.

Add infrastructure for a USB device blocklist.

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

Manual testing of this is difficult. I added a real device to the
blocklist and verified that it was not returned by
navigator.usb.getDevices() and was not listed in the chooser.

BUG=674353
Committed: https://crrev.com/eb1d24d32857475f3b506ad69bf17db1139f1011
Cr-Commit-Position: refs/heads/master@{#438981}

[Reilly Grant (use Gerrit), 2016-12-15 01:19:23]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 01:19:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2016-12-15 01:25:42]

reillyg@chromium.org changed reviewers:
+ scheib@chromium.org

[Reilly Grant (use Gerrit), 2016-12-15 01:25:42]

Please take a look.

[commit-bot: I haz the power, 2016-12-15 01:27:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 01:27:51]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[scheib, 2016-12-15 18:43:56]

LGTM with comment suggestion and a suggestion that you create a manual TEST=
line for this in the change description. Seems important to verify that it
really truly works in the full application.

https://codereview.chromium.org/2581543002/diff/1/chrome/browser/usb/usb_bloc...
File chrome/browser/usb/usb_blocklist.h (right):

https://codereview.chromium.org/2581543002/diff/1/chrome/browser/usb/usb_bloc...
chrome/browser/usb/usb_blocklist.h:24: // should be be accessible. These fields
correspond to the idVendor, idProduct
'be be' -> 'not be'

[Reilly Grant (use Gerrit), 2016-12-15 23:20:39]

Description was changed from

==========
Add infrastructure for a USB device blocklist.

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

BUG=674353
==========

to

==========
Add infrastructure for a USB device blocklist.

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

TEST=Added a real device to the blocklist and verified that it was not returned
by navigator.usb.getDevices() and was not listed in the chooser.
BUG=674353
==========

[Reilly Grant (use Gerrit), 2016-12-15 23:21:03]

https://codereview.chromium.org/2581543002/diff/1/chrome/browser/usb/usb_bloc...
File chrome/browser/usb/usb_blocklist.h (right):

https://codereview.chromium.org/2581543002/diff/1/chrome/browser/usb/usb_bloc...
chrome/browser/usb/usb_blocklist.h:24: // should be be accessible. These fields
correspond to the idVendor, idProduct
On 2016/12/15 18:43:56, scheib wrote:
> 'be be' -> 'not be'

Done.

[Reilly Grant (use Gerrit), 2016-12-15 23:21:10]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-12-15 23:21:11]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2581543002/#ps20001
(title: "Fix typo.")

[commit-bot: I haz the power, 2016-12-15 23:22:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-12-16 00:23:52]

The CQ bit was unchecked by scheib@chromium.org

[Reilly Grant (use Gerrit), 2016-12-16 01:04:46]

Description was changed from

==========
Add infrastructure for a USB device blocklist.

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

TEST=Added a real device to the blocklist and verified that it was not returned
by navigator.usb.getDevices() and was not listed in the chooser.
BUG=674353
==========

to

==========
Add infrastructure for a USB device blocklist.

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

Manual testing of this is difficult. I added a real device to the
blocklist and verified that it was not returned by
navigator.usb.getDevices() and was not listed in the chooser.

BUG=674353
==========

[Reilly Grant (use Gerrit), 2016-12-16 01:04:53]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-12-16 01:05:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 01:54:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481850293479940,
"parent_rev": "03120544d45456eaf17de288261d2bfdec289f9f", "commit_rev":
"ede94d24cff456e88faeb435a2c008e0acac41a9"}

[commit-bot: I haz the power, 2016-12-16 01:54:50]

Description was changed from

==========
Add infrastructure for a USB device blocklist.

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

Manual testing of this is difficult. I added a real device to the
blocklist and verified that it was not returned by
navigator.usb.getDevices() and was not listed in the chooser.

BUG=674353
==========

to

==========
Add infrastructure for a USB device blocklist.

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

Manual testing of this is difficult. I added a real device to the
blocklist and verified that it was not returned by
navigator.usb.getDevices() and was not listed in the chooser.

BUG=674353

Review-Url: https://codereview.chromium.org/2581543002
==========

[commit-bot: I haz the power, 2016-12-16 01:54:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-16 01:57:21]

Description was changed from

==========
Add infrastructure for a USB device blocklist.

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

Manual testing of this is difficult. I added a real device to the
blocklist and verified that it was not returned by
navigator.usb.getDevices() and was not listed in the chooser.

BUG=674353

Review-Url: https://codereview.chromium.org/2581543002
==========

to

==========
Add infrastructure for a USB device blocklist.

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

Manual testing of this is difficult. I added a real device to the
blocklist and verified that it was not returned by
navigator.usb.getDevices() and was not listed in the chooser.

BUG=674353

Committed: https://crrev.com/eb1d24d32857475f3b506ad69bf17db1139f1011
Cr-Commit-Position: refs/heads/master@{#438981}
==========

[commit-bot: I haz the power, 2016-12-16 01:57:22]

Patchset 2 (id:??) landed as
https://crrev.com/eb1d24d32857475f3b506ad69bf17db1139f1011
Cr-Commit-Position: refs/heads/master@{#438981}