Refactor ArcBridgeTest.

Refactor ArcBridgeTest.

This is preparation to split ArcSession running part
from ArcbridgeService.
- Remove friend test declaration, and use public interface only.
- Rework ArcBridgeTest so that we can almost simply rename
  the ArcBridgeServiceImpl.
- Use EXPECT rather than ASSERT.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Committed: https://crrev.com/10eca614af2ff7e3bc0f37b8f481558a562e10a6
Cr-Commit-Position: refs/heads/master@{#439373}

[hidehiko, 2016-12-16 10:09:54]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 10:10:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hidehiko, 2016-12-16 12:14:33]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2016-12-16 12:14:34]

For better code review-ability, I split this CL from crrev.com/2574013003. Hope
it is also better for you. PTAL.

[commit-bot: I haz the power, 2016-12-16 12:25:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 12:25:48]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-12-16 21:11:10]

lgtm

https://codereview.chromium.org/2581533004/diff/1/components/arc/arc_bridge_s...
File components/arc/arc_bridge_service_unittest.cc (right):

https://codereview.chromium.org/2581533004/diff/1/components/arc/arc_bridge_s...
components/arc/arc_bridge_service_unittest.cc:38: service_.reset(new
ArcBridgeServiceImpl(nullptr));
nit: service_ = base::MakeUnique<ArcBridgeServiceImpl>(nullptr);

// You have seem to have been migrating all other calls like this to use
MakeUnique.

[hidehiko, 2016-12-18 16:40:24]

Thank you for review. Submitting.

https://codereview.chromium.org/2581533004/diff/1/components/arc/arc_bridge_s...
File components/arc/arc_bridge_service_unittest.cc (right):

https://codereview.chromium.org/2581533004/diff/1/components/arc/arc_bridge_s...
components/arc/arc_bridge_service_unittest.cc:38: service_.reset(new
ArcBridgeServiceImpl(nullptr));
On 2016/12/16 21:11:10, Luis Héctor Chávez wrote:
> nit: service_ = base::MakeUnique<ArcBridgeServiceImpl>(nullptr);
> 
> // You have seem to have been migrating all other calls like this to use
> MakeUnique.

Done.

[hidehiko, 2016-12-18 16:40:38]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2016-12-18 16:40:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2581533004/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-12-18 16:40:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 17:07:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482079238897730,
"parent_rev": "46765d910cf8d6bac5b78a487719006e525eed0c", "commit_rev":
"2263406eafbd07982dd2c1b5ebd371d0440942c2"}

[commit-bot: I haz the power, 2016-12-18 17:08:13]

Description was changed from

==========
Refactor ArcBridgeTest.

This is preparation to split ArcSession running part
from ArcbridgeService.
- Remove friend test declaration, and use public interface only.
- Rework ArcBridgeTest so that we can almost simply rename
  the ArcBridgeServiceImpl.
- Use EXPECT rather than ASSERT.

BUG=657687
BUG=b/31079732
TEST=Ran bots.
==========

to

==========
Refactor ArcBridgeTest.

This is preparation to split ArcSession running part
from ArcbridgeService.
- Remove friend test declaration, and use public interface only.
- Rework ArcBridgeTest so that we can almost simply rename
  the ArcBridgeServiceImpl.
- Use EXPECT rather than ASSERT.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2581533004
==========

[commit-bot: I haz the power, 2016-12-18 17:08:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-18 17:10:54]

Description was changed from

==========
Refactor ArcBridgeTest.

This is preparation to split ArcSession running part
from ArcbridgeService.
- Remove friend test declaration, and use public interface only.
- Rework ArcBridgeTest so that we can almost simply rename
  the ArcBridgeServiceImpl.
- Use EXPECT rather than ASSERT.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2581533004
==========

to

==========
Refactor ArcBridgeTest.

This is preparation to split ArcSession running part
from ArcbridgeService.
- Remove friend test declaration, and use public interface only.
- Rework ArcBridgeTest so that we can almost simply rename
  the ArcBridgeServiceImpl.
- Use EXPECT rather than ASSERT.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Committed: https://crrev.com/10eca614af2ff7e3bc0f37b8f481558a562e10a6
Cr-Commit-Position: refs/heads/master@{#439373}
==========

[commit-bot: I haz the power, 2016-12-18 17:10:55]

Patchset 2 (id:??) landed as
https://crrev.com/10eca614af2ff7e3bc0f37b8f481558a562e10a6
Cr-Commit-Position: refs/heads/master@{#439373}