Show the Data Saver string for offline previews when Data Saver is enabled

Show the Data Saver string for offline previews when Data Saver is enabled

When a user is a Data Saver user and is shown an offline preview,
they should be shown the Data Saver string (i.e., "Saved Data.").

When they are not a Data Saver user (i.e., Data Saver is disabled),
the string should remain as "Faster Page Loaded."

BUG=674754
Committed: https://crrev.com/278b11efa32d7f219eeb0bb49c1bc8cb0d907a19
Cr-Commit-Position: refs/heads/master@{#439303}

[RyanSturm, 2016-12-15 23:32:27]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[RyanSturm, 2016-12-15 23:33:01]

ryansturm@chromium.org changed reviewers:
+ bengr@chromium.org

[RyanSturm, 2016-12-15 23:33:02]

bengr: PTAL, thanks

[commit-bot: I haz the power, 2016-12-15 23:34:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bengr, 2016-12-16 00:38:43]

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/previews/pre...
File chrome/browser/previews/previews_infobar_delegate.cc (right):

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/previews/pre...
chrome/browser/previews/previews_infobar_delegate.cc:120: (is_data_saver_user_)
? IDS_PREVIEWS_INFOBAR_SAVED_DATA_TITLE
Seems you want to choose a string when you create an infobar, so why not store
the string id instead of is_data_saver_user_? That would be less confusing,
because afaik the user could disable data saver while the infobar is being
shown.

[commit-bot: I haz the power, 2016-12-16 03:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 03:41:47]

Dry run: This issue passed the CQ dry run.

[bengr, 2016-12-16 16:45:30]

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/net/spdyprox...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
(right):

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/net/spdyprox...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc:44:
web_contents, PreviewsInfoBarDelegate::LOFI, true /* is_data_saver_user*/,
nit: Add a space after 'user'

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/previews/pre...
File chrome/browser/previews/previews_infobar_tab_helper.cc (right):

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/previews/pre...
chrome/browser/previews/previews_infobar_tab_helper.cc:93: is_data_saver_user /*
is_data_saver_user*/,
Why not just replace this with drp_settings && drp_settings->IsDRPEnabled()?

[RyanSturm, 2016-12-16 18:44:55]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 18:45:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-12-16 18:54:40]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 18:55:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-12-16 19:00:01]

Patchset #3 (id:40001) has been deleted

[RyanSturm, 2016-12-16 19:00:10]

Patchset #2 (id:20001) has been deleted

[RyanSturm, 2016-12-16 19:02:10]

bengr: ptal

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/net/spdyprox...
File chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
(right):

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/net/spdyprox...
chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc:44:
web_contents, PreviewsInfoBarDelegate::LOFI, true /* is_data_saver_user*/,
On 2016/12/16 16:45:30, bengr wrote:
> nit: Add a space after 'user'

Done.

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/previews/pre...
File chrome/browser/previews/previews_infobar_delegate.cc (right):

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/previews/pre...
chrome/browser/previews/previews_infobar_delegate.cc:120: (is_data_saver_user_)
? IDS_PREVIEWS_INFOBAR_SAVED_DATA_TITLE
On 2016/12/16 00:38:43, bengr wrote:
> Seems you want to choose a string when you create an infobar, so why not store
> the string id instead of is_data_saver_user_? That would be less confusing,
> because afaik the user could disable data saver while the infobar is being
> shown.

Done.

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/previews/pre...
File chrome/browser/previews/previews_infobar_tab_helper.cc (right):

https://codereview.chromium.org/2581533003/diff/1/chrome/browser/previews/pre...
chrome/browser/previews/previews_infobar_tab_helper.cc:93: is_data_saver_user /*
is_data_saver_user*/,
On 2016/12/16 16:45:30, bengr wrote:
> Why not just replace this with drp_settings && drp_settings->IsDRPEnabled()?

Done.

[bengr, 2016-12-16 20:35:20]

lgtm

[RyanSturm, 2016-12-17 00:22:12]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2016-12-17 00:23:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 02:57:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481934132932930,
"parent_rev": "b65af021aff7ff0e4e669c6ed668d900004b1e9a", "commit_rev":
"63e7ec2572602282b379b1d2e9b2eae99506ba3a"}

[commit-bot: I haz the power, 2016-12-17 02:57:52]

Description was changed from

==========
Show the Data Saver string for offline previews when Data Saver is enabled

When a user is a Data Saver user and is shown an offline preview,
they should be shown the Data Saver string (i.e., "Saved Data.").

When they are not a Data Saver user (i.e., Data Saver is disabled),
the string should remain as "Faster Page Loaded."

BUG=674754
==========

to

==========
Show the Data Saver string for offline previews when Data Saver is enabled

When a user is a Data Saver user and is shown an offline preview,
they should be shown the Data Saver string (i.e., "Saved Data.").

When they are not a Data Saver user (i.e., Data Saver is disabled),
the string should remain as "Faster Page Loaded."

BUG=674754

Review-Url: https://codereview.chromium.org/2581533003
==========

[commit-bot: I haz the power, 2016-12-17 02:57:53]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-12-17 02:59:41]

Description was changed from

==========
Show the Data Saver string for offline previews when Data Saver is enabled

When a user is a Data Saver user and is shown an offline preview,
they should be shown the Data Saver string (i.e., "Saved Data.").

When they are not a Data Saver user (i.e., Data Saver is disabled),
the string should remain as "Faster Page Loaded."

BUG=674754

Review-Url: https://codereview.chromium.org/2581533003
==========

to

==========
Show the Data Saver string for offline previews when Data Saver is enabled

When a user is a Data Saver user and is shown an offline preview,
they should be shown the Data Saver string (i.e., "Saved Data.").

When they are not a Data Saver user (i.e., Data Saver is disabled),
the string should remain as "Faster Page Loaded."

BUG=674754

Committed: https://crrev.com/278b11efa32d7f219eeb0bb49c1bc8cb0d907a19
Cr-Commit-Position: refs/heads/master@{#439303}
==========

[commit-bot: I haz the power, 2016-12-17 02:59:42]

Patchset 2 (id:??) landed as
https://crrev.com/278b11efa32d7f219eeb0bb49c1bc8cb0d907a19
Cr-Commit-Position: refs/heads/master@{#439303}