Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_layout_model.h

Issue 2581513002: Replace hard-coded colors from ui::NativeTheme for consistency and accessibility. (Closed)
Patch Set: Using NativeTheme::GetInstanceForNativeUi() to get NativeThemeMac instance Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_layout_model.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_layout_model.h b/chrome/browser/ui/autofill/autofill_popup_layout_model.h
index 564b50cb48286f3ab1ea2c5168d071fe01385655..28eaccc22a2d8f7d2492355b81b2eb8e34cd8181 100644
--- a/chrome/browser/ui/autofill/autofill_popup_layout_model.h
+++ b/chrome/browser/ui/autofill/autofill_popup_layout_model.h
@@ -14,6 +14,7 @@
#include "ui/gfx/font_list.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/native_widget_types.h"
+#include "ui/native_theme/native_theme.h"
namespace gfx {
class ImageSkia;
@@ -74,8 +75,11 @@ class AutofillPopupLayoutModel {
const gfx::FontList& GetValueFontListForRow(size_t index) const;
const gfx::FontList& GetLabelFontListForRow(size_t index) const;
- // Returns the value font color of the row item according to its |index|.
- SkColor GetValueFontColorForRow(size_t index) const;
+ // Returns the value font color ID of the row item according to its |index|.
+ ui::NativeTheme::ColorId GetValueFontColorIDForRow(size_t index) const;
+
+ // TODO(jiahuiguo) Add a function to return label fonr color ID for cocoa impl
Jared Saul 2017/01/04 19:51:38 s/fonr/font
jiahuiguo 2017/01/05 19:21:20 Done.
+ // ui::NativeTheme::ColorId GetLabelFontColorIDForRow(size_t index) const;
// Returns the icon image of the item at |index| in the popup.
gfx::ImageSkia GetIconImage(size_t index) const;

Powered by Google App Engine
This is Rietveld 408576698