Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2524)

Issue 2581503002: Adds additional_client_area to client area (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, rjkroege, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds additional_client_area to client area This is needed for chrome. BUG=663525 TEST=none R=erg@chromium.org Committed: https://crrev.com/e7880ac7ec0eb3e12c2729305e10fe77d78d64ab Cr-Commit-Position: refs/heads/master@{#438742}

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -16 lines) Patch
M services/ui/ws/window_manager_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_host_mus.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/mus/window_tree_host_mus.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.h View 3 chunks +10 lines, -0 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 1 2 5 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
sky
This is also adds the ability to turn off updating the client area.
4 years ago (2016-12-14 23:37:39 UTC) #1
Elliot Glaysher
lgtm, but... On 2016/12/14 23:37:39, sky wrote: > This is also adds the ability to ...
4 years ago (2016-12-14 23:49:32 UTC) #4
sky
On 2016/12/14 23:49:32, Elliot Glaysher wrote: > lgtm, but... > > On 2016/12/14 23:37:39, sky ...
4 years ago (2016-12-15 00:04:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581503002/40001
4 years ago (2016-12-15 03:45:53 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-15 04:37:13 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-15 04:41:24 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e7880ac7ec0eb3e12c2729305e10fe77d78d64ab
Cr-Commit-Position: refs/heads/master@{#438742}

Powered by Google App Engine
This is Rietveld 408576698