Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 2581443002: [stubs] Add AllocationFlags parameter to AllocateJSObjectFromMap (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Add AllocationFlags parameter to AllocateJSObjectFromMap Committed: https://crrev.com/687616507277d6602fc3b6cf89cf38d32e028bc6 Cr-Commit-Position: refs/heads/master@{#41702}

Patch Set 1 #

Patch Set 2 : Add flags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/code-stub-assembler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
gsathya
4 years ago (2016-12-14 23:35:19 UTC) #4
Igor Sheludko
lgtm
4 years ago (2016-12-14 23:42:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581443002/20001
4 years ago (2016-12-15 01:06:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-15 01:08:09 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 01:08:41 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/687616507277d6602fc3b6cf89cf38d32e028bc6
Cr-Commit-Position: refs/heads/master@{#41702}

Powered by Google App Engine
This is Rietveld 408576698