Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2581423002: DevTools: Decorate requests from SW on Timeline (Closed)

Created:
4 years ago by ahmetemirercin
Modified:
4 years ago
Reviewers:
kenjibaheux, paulirish, alph
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Decorate requests from SW on Timeline BUG=672920 Committed: https://crrev.com/10de153f25f4b0a8600583100d1b38007b26cd82 Cr-Commit-Position: refs/heads/master@{#439294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ahmetemirercin
Please take a look at this? (I couldn't add issue owner since e-mail is shown ...
4 years ago (2016-12-17 00:36:05 UTC) #3
alph
Great! Thanks for implementing it. lgtm
4 years ago (2016-12-17 00:59:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581423002/1
4 years ago (2016-12-17 01:00:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-17 02:34:16 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/10de153f25f4b0a8600583100d1b38007b26cd82 Cr-Commit-Position: refs/heads/master@{#439294}
4 years ago (2016-12-17 02:37:22 UTC) #12
paulirish
4 years ago (2016-12-17 03:41:18 UTC) #13
Message was sent while issue was closed.
fantastic CL. thanksk ahmet!! :D

Powered by Google App Engine
This is Rietveld 408576698