Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2581413002:
Fix tab switcher screenshots for interstitials. (Closed)
DescriptionFix tab switcher screenshots for interstitials.
In particular, interstitials "mask" the underlying webcontents
and we need to handle them specially. We do this by capturing
the correct content::RenderViewHost from the interstitial
instead of the webcontents it sits on top of.
BUG=675283
Committed: https://crrev.com/5eb9ee95588a470a55b89d6e65ab67b0fdaff802
Cr-Commit-Position: refs/heads/master@{#440772}
Patch Set 1 #Patch Set 2 : Rebased #Messages
Total messages: 18 (9 generated)
tedchoc@chromium.org changed reviewers: + dtrainor@chromium.org, mdjones@chromium.org
PTAL
lgtm but could you add a bit to the description? Something like, "get the RenderViewHost from the interstitial if it is showing instead of the page's WebContents".
lgtm
Description was changed from ========== Fix tab switcher screenshots for interstitials. BUG=675283 ========== to ========== Fix tab switcher screenshots for interstitials. In particular, interstitials "mask" the underlying webcontents and we need to handle them specially. We do this by capturing the correct content::RenderViewHost from the interstitial instead of the webcontents it sits on top of. BUG=675283 ==========
On 2016/12/19 17:07:59, mdjones wrote: > lgtm but could you add a bit to the description? Something like, "get the > RenderViewHost from the interstitial if it is showing instead of the page's > WebContents". Done. updated the description
The CQ bit was checked by tedchoc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by tedchoc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mdjones@chromium.org, dtrainor@chromium.org Link to the patchset: https://codereview.chromium.org/2581413002/#ps20001 (title: "Rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482862500264880,
"parent_rev": "6ea0532f1e7824efb7073761c1630b57d7459ad9", "commit_rev":
"9702e9aad0ebfd330757ad8e6ba3ef7e23572ec1"}
Message was sent while issue was closed.
Description was changed from ========== Fix tab switcher screenshots for interstitials. In particular, interstitials "mask" the underlying webcontents and we need to handle them specially. We do this by capturing the correct content::RenderViewHost from the interstitial instead of the webcontents it sits on top of. BUG=675283 ========== to ========== Fix tab switcher screenshots for interstitials. In particular, interstitials "mask" the underlying webcontents and we need to handle them specially. We do this by capturing the correct content::RenderViewHost from the interstitial instead of the webcontents it sits on top of. BUG=675283 Review-Url: https://codereview.chromium.org/2581413002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix tab switcher screenshots for interstitials. In particular, interstitials "mask" the underlying webcontents and we need to handle them specially. We do this by capturing the correct content::RenderViewHost from the interstitial instead of the webcontents it sits on top of. BUG=675283 Review-Url: https://codereview.chromium.org/2581413002 ========== to ========== Fix tab switcher screenshots for interstitials. In particular, interstitials "mask" the underlying webcontents and we need to handle them specially. We do this by capturing the correct content::RenderViewHost from the interstitial instead of the webcontents it sits on top of. BUG=675283 Committed: https://crrev.com/5eb9ee95588a470a55b89d6e65ab67b0fdaff802 Cr-Commit-Position: refs/heads/master@{#440772} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5eb9ee95588a470a55b89d6e65ab67b0fdaff802 Cr-Commit-Position: refs/heads/master@{#440772} |
