cros: Remaining interfaces for DBUS biometrics client.

chromeos/dbus/biod_record_client.cc

Index: chromeos/dbus/biod_record_client.cc
diff --git a/chromeos/dbus/biod_record_client.cc b/chromeos/dbus/biod_record_client.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3729f2040fe58986ace29ad26af258d1542505b8
--- /dev/null
+++ b/chromeos/dbus/biod_record_client.cc
@@ -0,0 +1,98 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/dbus/biod_record_client.h"
+
+#include <stdint.h>
+
+#include "base/bind.h"
+#include "base/macros.h"
+#include "dbus/bus.h"
+#include "dbus/message.h"
+#include "dbus/object_path.h"
+#include "dbus/object_proxy.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
+
+namespace chromeos {
+
+// The BiodRecordClient implementation used in production.
+class BiodRecordClientImpl : public BiodRecordClient {
+ public:
+  BiodRecordClientImpl() : weak_ptr_factory_(this) {}
+
+  ~BiodRecordClientImpl() override {}
+
+  void SetLabel(const dbus::ObjectPath& record_path,
+                const std::string& label) override {
+    dbus::MethodCall method_call(biod::kRecordInterface,
+                                 biod::kRecordSetLabelMethod);
+    dbus::MessageWriter writer(&method_call);
+    writer.AppendString(label);
+
+    dbus::ObjectProxy* record_proxy =
+        bus_->GetObjectProxy(biod::kBiodServiceName, record_path);
+    record_proxy->CallMethod(&method_call,
+                             dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+                             dbus::ObjectProxy::EmptyResponseCallback());
+  }
+
+  void Remove(const dbus::ObjectPath& record_path) override {
+    dbus::MethodCall method_call(biod::kRecordInterface,
+                                 biod::kRecordRemoveMethod);
+
+    dbus::ObjectProxy* record_proxy =
+        bus_->GetObjectProxy(biod::kBiodServiceName, record_path);
+    record_proxy->CallMethod(&method_call,
+                             dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+                             dbus::ObjectProxy::EmptyResponseCallback());
+  }
+
+  void RequestLabel(const dbus::ObjectPath& record_path,
+                    const LabelCallback& callback) override {
+    dbus::MethodCall method_call(dbus::kDBusPropertiesInterface,
+                                 dbus::kDBusPropertiesGet);
+    dbus::MessageWriter writer(&method_call);
+    writer.AppendString(biod::kRecordInterface);
+    writer.AppendString(biod::kRecordLabelProperty);
+
+    dbus::ObjectProxy* record_proxy =
+        bus_->GetObjectProxy(biod::kBiodServiceName, record_path);
+    record_proxy->CallMethod(
+        &method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+        base::Bind(&BiodRecordClientImpl::OnRequestLabel,
+                   weak_ptr_factory_.GetWeakPtr(), callback));
+  }
+
+ protected:
+  void Init(dbus::Bus* bus) override { bus_ = bus; }
+
+ private:
+  void OnRequestLabel(const LabelCallback& callback, dbus::Response* response) {
+    dbus::MessageReader reader(response);

[stevenjb, 2017/03/22 20:57:53]

I forget what happens if the request fails, do we need to check the response? I
guess it will just fail in reader.Pop...?

[sammiequon, 2017/03/23 18:30:37]

It seems like response might be empty and it could also fail while reading the
response.

+    std::string result;
+    if (reader.PopVariantOfString(&result)) {
+      callback.Run(result);

[stevenjb, 2017/03/22 20:57:53]

We should log an error and call the callback with an empty or error result on
failure, otherwise code expecting a result might just stick around waiting.

[sammiequon, 2017/03/23 18:30:37]

Done.

+    }
+  }
+
+  dbus::Bus* bus_;
+
+  // Note: This should remain the last member so it'll be destroyed and
+  // invalidate its weak pointers before any other members are destroyed.
+  base::WeakPtrFactory<BiodRecordClientImpl> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(BiodRecordClientImpl);
+};
+
+BiodRecordClient::BiodRecordClient() {}
+
+BiodRecordClient::~BiodRecordClient() {}
+
+// static
+BiodRecordClient* BiodRecordClient::Create(
+    DBusClientImplementationType /* type */) {
+  return new BiodRecordClientImpl();
+}
+
+}  // namespace chromeos