cros: Remaining interfaces for DBUS biometrics client.

chromeos/dbus/biod/biod_client.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_BIOD_BIOD_CLIENT_H_
 #define CHROMEOS_DBUS_BIOD_BIOD_CLIENT_H_
 
 #include <string>
 #include <unordered_map>
 #include <vector>
@@ skipping 59 matching lines @@
   // UserRecordsCallback is used for the GetRecordsForUser method. It receives
   // one argument which contains a list of the stored records' object paths for
   // a given user.
   using UserRecordsCallback =
       base::Callback<void(const std::vector<dbus::ObjectPath>&)>;
 
   // BiometricTypeCallback is used for the GetType method. It receives
   // one argument which states the type of biometric.
   using BiometricTypeCallback = base::Callback<void(biod::BiometricType)>;
 
+  // LabelCallback is for the RequestLabel method. It receives one argument

[Daniel Erat, 2017/04/03 19:58:18]

RequestRecordLabel

[sammiequon, 2017/04/03 21:35:09]

Done.

+  // which is the label of the record.
+  using LabelCallback = base::Callback<void(const std::string&)>;

[Daniel Erat, 2017/04/03 19:58:18]

i think you can include a parameter name here, e.g.

using LabelCallback = base::Callback<void(const std::string& label)>;

you can delete the second sentence of the comment, then.

[sammiequon, 2017/04/03 21:35:09]

Done.

+
   // Starts the biometric enroll session. |callback| is called with the object
   // path of the current enroll session after the method succeeds. |user_id|
   // contains the unique identifier for the owner of the biometric. |label| is
   // the the human readable label the user gave the biometric.
   virtual void StartEnrollSession(const std::string& user_id,
                                   const std::string& label,
                                   const ObjectPathCallback& callback) = 0;
 
   // Gets all the records registered with this biometric. |callback| is called
   // with all the object paths of the records with |user_id| after this method
   // succeeds. |user_id| contains the unique identifier for the owner of the
   // biometric.
   virtual void GetRecordsForUser(const std::string& user_id,
                                  const UserRecordsCallback& callback) = 0;
 
   // Irreversibly destroys all records registered.
   virtual void DestroyAllRecords() = 0;
 
   // Starts the biometric auth session. |callback| is called with the object
   // path of the auth session after the method succeeds.
   virtual void StartAuthSession(const ObjectPathCallback& callback) = 0;
 
   // Requests the type of biometric. |callback| is called with the biometric
   // type after the method succeeds.
   virtual void RequestType(const BiometricTypeCallback& callback) = 0;
 
+  // Cancels the enroll session at |enroll_session_path|.
+  virtual void CancelEnrollSession(
+      const dbus::ObjectPath& enroll_session_path) = 0;
+
+  // Ends the auth session at |auth_session_path|.
+  virtual void EndAuthSession(const dbus::ObjectPath& auth_session_path) = 0;
+
+  // Changes the label of the record at |record_path| to |label|.
+  virtual void SetRecordLabel(const dbus::ObjectPath& record_path,
+                              const std::string& label) = 0;
+
+  // Removes the record at |record_path|. This record will no longer be able to
+  // used for authentication.
+  virtual void RemoveRecord(const dbus::ObjectPath& record_path) = 0;
+
+  // Requests the label of the record at |record_path|. |callback| is called
+  // with the label of the record.
+  virtual void RequestRecordLabel(const dbus::ObjectPath& record_path,
+                                  const LabelCallback& callback) = 0;
+
   // Creates the instance.
   static BiodClient* Create(DBusClientImplementationType type);
 
  protected:
   friend class BiodClientTest;
 
   // Create() should be used instead.
   BiodClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BiodClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_BIOD_BIOD_CLIENT_H_