Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 2581353002: Use the Windows MDM API to check if the machine is being managed. (Closed)
Patch Set: Address review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main_win.cc
diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc
index 1e0113dc688d765c1e13b95140624bb4cb2129fa..ede859552cd0ac512a0afff8c2109bb378387b1a 100644
--- a/chrome/browser/chrome_browser_main_win.cc
+++ b/chrome/browser/chrome_browser_main_win.cc
@@ -311,10 +311,11 @@ void ChromeBrowserMainPartsWin::PreMainMessageLoopStart() {
}
int ChromeBrowserMainPartsWin::PreCreateThreads() {
-// Record whether the machine is domain joined in a crash key. This will be used
-// to better identify whether crashes are from enterprise users.
- base::debug::SetCrashKeyValue(crash_keys::kEnrolledToDomain,
- base::win::IsEnrolledToDomain() ? "yes" : "no");
+ // Record whether the machine is domain joined in a crash key. This will be
sky 2017/02/15 21:27:15 Update comment to say enterprise managed?
Roger Tawa OOO till Jul 10th 2017/02/17 19:20:13 Done.
+ // used to better identify whether crashes are from enterprise users.
+ base::debug::SetCrashKeyValue(
+ crash_keys::kEnrolledToDomain,
sky 2017/02/15 21:27:15 Should this key be renamed to match?
Roger Tawa OOO till Jul 10th 2017/02/17 19:20:13 Done. Chatted with crash folks and they are good
+ base::win::IsEnterpriseManaged() ? "yes" : "no");
int rv = ChromeBrowserMainParts::PreCreateThreads();

Powered by Google App Engine
This is Rietveld 408576698