chrome/browser/component_updater/chrome_component_updater_configurator.cc - Issue 2581353002: Use the Windows MDM API to check if the machine is being managed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/chrome_component_updater_configurator.cc

Issue 2581353002: Use the Windows MDM API to check if the machine is being managed. (Closed)

Patch Set: Address review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_browser_main_win.cc ('K') | « chrome/browser/chrome_browser_main_win.cc ('k') | chrome/browser/prefs/chrome_pref_service_factory.cc » ('j') | components/policy/core/common/policy_loader_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/chrome_component_updater_configurator.cc

diff --git a/chrome/browser/component_updater/chrome_component_updater_configurator.cc b/chrome/browser/component_updater/chrome_component_updater_configurator.cc

index 2fccab7600c25f879debd3408cc1d674928a4498..9ac75ffaa9e097def387a7a8f81f020a923349ef 100644

--- a/chrome/browser/component_updater/chrome_component_updater_configurator.cc

+++ b/chrome/browser/component_updater/chrome_component_updater_configurator.cc

@@ -149,9 +149,8 @@ std::string ChromeConfigurator::ExtraRequestParams() const {

std::string ChromeConfigurator::GetDownloadPreference() const {

#if defined(OS_WIN)

- // This group policy is supported only on Windows and only for computers

- // which are joined to a Windows domain.

- return base::win::IsEnrolledToDomain()

+ // This group policy is supported only on Windows and only for enterprises.

+ return base::win::IsEnterpriseManaged()

? base::SysWideToUTF8(

GoogleUpdateSettings::GetDownloadPreference())

: std::string("");

sky 2017/02/15 21:27:15 std::string("") -> std::string()

Roger Tawa OOO till Jul 10th 2017/02/17 19:20:13 Done.