Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2581293002: [PR] Fix selection when cancelling out of add billing address flow (Closed)

Created:
4 years ago by Mathieu
Modified:
4 years ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PR] Fix selection when cancelling out of add billing address flow Previously, cancelling out of ADD ADDRESS flow in card editor would always clear the billing address dropdown selection. We now restore it properly. BUG=675008 TEST=PaymentRequestBillingAddress* Committed: https://crrev.com/95937f0e845bff960f00df8d546df266709d9f15 Cr-Commit-Position: refs/heads/master@{#439217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java View 2 chunks +61 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Mathieu
PTAL
4 years ago (2016-12-16 19:18:27 UTC) #3
please use gerrit instead
lgtm
4 years ago (2016-12-16 20:58:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581293002/1
4 years ago (2016-12-16 21:08:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 22:22:32 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-16 22:25:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95937f0e845bff960f00df8d546df266709d9f15
Cr-Commit-Position: refs/heads/master@{#439217}

Powered by Google App Engine
This is Rietveld 408576698