Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 258123003: ContentView->ContentViewCore.getContainerView for SwipableOverlay's (Closed)

Created:
6 years, 7 months ago by Yaron
Modified:
6 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews
Visibility:
Public.

Description

ContentView->ContentViewCore.getContainerView for SwipableOverlay's Should depend on the model (CVC) and gets its View when adding to the view heirarchy. BUG=360664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267110

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 9 (0 generated)
Yaron
I'm not entirely sure about the getParent stuff but I think it's logically the same
6 years, 7 months ago (2014-04-29 16:28:07 UTC) #1
gone
lgtm
6 years, 7 months ago (2014-04-29 21:06:55 UTC) #2
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 7 months ago (2014-04-29 21:24:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/258123003/20001
6 years, 7 months ago (2014-04-29 21:25:51 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:19:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:19:09 UTC) #6
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 7 months ago (2014-04-29 22:48:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/258123003/20001
6 years, 7 months ago (2014-04-29 22:48:50 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 07:01:25 UTC) #9
Message was sent while issue was closed.
Change committed as 267110

Powered by Google App Engine
This is Rietveld 408576698