Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java

Issue 258123003: ContentView->ContentViewCore.getContainerView for SwipableOverlay's (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
index 9bb5fbc2e1ebeb7ef6ea438357f973f20c4db3d0..4e5e4bd029c1cd20d659ca0525bbc4e539c4f460 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java
@@ -31,7 +31,7 @@ import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.chrome.R;
-import org.chromium.content.browser.ContentView;
+import org.chromium.content.browser.ContentViewCore;
import org.chromium.ui.base.LocalizationUtils;
import org.chromium.ui.base.WindowAndroid;
import org.chromium.ui.base.WindowAndroid.IntentCallback;
@@ -152,18 +152,19 @@ public class AppBannerView extends SwipableOverlayView
private int mInstallState;
/**
- * Creates a BannerView and adds it to the given ContentView.
- * @param contentView ContentView to display the AppBannerView for.
+ * Creates a BannerView and adds it to the given ContentViewCore.
+ * @param contentViewCore ContentViewCore to display the AppBannerView for.
* @param observer Class that is alerted for AppBannerView events.
* @param data Data about the app.
* @return The created banner.
*/
- public static AppBannerView create(ContentView contentView, Observer observer, AppData data) {
- Context context = contentView.getContext().getApplicationContext();
+ public static AppBannerView create(
+ ContentViewCore contentViewCore, Observer observer,AppData data) {
+ Context context = contentViewCore.getContext().getApplicationContext();
AppBannerView banner =
(AppBannerView) LayoutInflater.from(context).inflate(BANNER_LAYOUT, null);
banner.initialize(observer, data);
- banner.addToView(contentView);
+ banner.addToView(contentViewCore);
return banner;
}

Powered by Google App Engine
This is Rietveld 408576698