Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2581163003: Don't hold onto SkBitmap in mus_demo. (Closed)

Created:
4 years ago by kylechar
Modified:
4 years ago
Reviewers:
mfomitchev
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't hold onto SkBitmap in mus_demo. There is no need to hold onto the SkBitmap object as a member variable in MusDemo. It was originally retained so that the pixel buffer didn't need to be reallocated for each frame (a copy of the pixel buffer was made when submitting the frame). However, the pixel buffer is now locked and ownership is shared with the gfx::ImageSkiaRep, requiring a new pixel buffer to be allocated for each frame regardless. Remove |bitmap_| member variable. BUG=none Committed: https://crrev.com/ab87dd7cd4a7d855c8b43b848618810f5c892143 Cr-Commit-Position: refs/heads/master@{#439129}

Patch Set 1 #

Patch Set 2 : Move include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M services/ui/demo/mus_demo.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kylechar
4 years ago (2016-12-16 14:29:11 UTC) #2
mfomitchev
Sure, lgtm.
4 years ago (2016-12-16 16:57:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581163003/20001
4 years ago (2016-12-16 16:58:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 17:10:59 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-16 17:13:14 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab87dd7cd4a7d855c8b43b848618810f5c892143
Cr-Commit-Position: refs/heads/master@{#439129}

Powered by Google App Engine
This is Rietveld 408576698