Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 2581153003: Reland of Delay Input.dispatchKeyEvent response until after key event ack. (Closed)

Created:
4 years ago by samuong
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Delay Input.dispatchKeyEvent response until after key event ack. This was originally landed in crrev.com/437706, but was reverted in crrev.com/437706. This CL contains no changes from the original CL, except that I've rebased and fixed some merge conflicts. BUG=chromedriver:1506 TBR=pfeldman@chromium.org Committed: https://crrev.com/94fba022cb393c5016147649b7145d006c10f264 Cr-Commit-Position: refs/heads/master@{#439224}

Patch Set 1 #

Patch Set 2 : rebase and resolve merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -17 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 5 chunks +78 lines, -10 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.h View 5 chunks +23 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 7 chunks +65 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 5 chunks +10 lines, -0 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
samuong
This CL should still work, but I've noticed that some time between now and when ...
4 years ago (2016-12-16 19:58:32 UTC) #2
dgozman
rs lgtm Don't worry about Detached vs Disable. We are in the transition process, I ...
4 years ago (2016-12-16 20:09:55 UTC) #3
samuong
Thanks!
4 years ago (2016-12-16 20:58:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581153003/20001
4 years ago (2016-12-16 21:00:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/328116)
4 years ago (2016-12-16 21:17:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581153003/20001
4 years ago (2016-12-16 21:18:50 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 23:06:16 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/94fba022cb393c5016147649b7145d006c10f264 Cr-Commit-Position: refs/heads/master@{#439224}
4 years ago (2016-12-16 23:08:49 UTC) #17
dgozman
4 years ago (2016-12-17 20:46:54 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2584193002/ by dgozman@chromium.org.

The reason for reverting is: This patch makes dispatchMouseEvent not respond for
anything except mouse moves.
This line is responsible:
https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/inpu....
Layout test inspector-protocol/input/dispatchMouseEvent.html times out
consistently..

Powered by Google App Engine
This is Rietveld 408576698