Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2581143003: implement LabeledStatement and Break in kernel (Closed)

Created:
4 years ago by Harry Terkelsen
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix some tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -73 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +2 lines, -2 lines 2 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 3 chunks +3 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 3 chunks +57 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/jump_handler.dart View 9 chunks +17 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 4 chunks +66 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/loop_handler.dart View 4 chunks +21 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
4 years ago (2016-12-16 23:05:08 UTC) #2
Siggi Cherem (dart-lang)
lgtm, very cool Harry! https://codereview.chromium.org/2581143003/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (left): https://codereview.chromium.org/2581143003/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#oldcode3226 pkg/compiler/lib/src/elements/modelx.dart:3226: labels = labels.prepend(result); It seems ...
4 years ago (2016-12-17 00:43:17 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/2581143003/diff/20001/pkg/compiler/lib/src/elements/modelx.dart File pkg/compiler/lib/src/elements/modelx.dart (left): https://codereview.chromium.org/2581143003/diff/20001/pkg/compiler/lib/src/elements/modelx.dart#oldcode3226 pkg/compiler/lib/src/elements/modelx.dart:3226: labels = labels.prepend(result); On 2016/12/17 00:43:16, Siggi Cherem (dart-lang) ...
4 years ago (2016-12-17 00:50:36 UTC) #4
Harry Terkelsen
4 years ago (2016-12-17 00:50:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f6c944aecf139f4df683a3bc12954de7f0d22cd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698