Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 2581143003: implement LabeledStatement and Break in kernel (Closed)
Patch Set: fix some tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | pkg/compiler/lib/src/js_backend/mirrors_analysis.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/elements/modelx.dart
diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart
index b47936705dbcfcc5c626bf94fc614aa0446c7506..c2d2e75ae8cc45f0d91cfc5d4ab4e79400a14816 100644
--- a/pkg/compiler/lib/src/elements/modelx.dart
+++ b/pkg/compiler/lib/src/elements/modelx.dart
@@ -3209,7 +3209,7 @@ class JumpTargetX implements JumpTarget {
final ExecutableElement executableContext;
final Node statement;
final int nestingLevel;
- Link<LabelDefinition> labels = const Link<LabelDefinition>();
+ List<LabelDefinition> labels = <LabelDefinition>[];
bool isBreakTarget = false;
bool isContinueTarget = false;
@@ -3223,7 +3223,7 @@ class JumpTargetX implements JumpTarget {
LabelDefinition addLabel(Label label, String labelName) {
LabelDefinition result = new LabelDefinitionX(label, labelName, this);
- labels = labels.prepend(result);
Siggi Cherem (dart-lang) 2016/12/17 00:43:16 It seems the order after this change will be rever
Harry Terkelsen 2016/12/17 00:50:36 The order doesn't matter because they are all labe
+ labels.add(result);
return result;
}
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | pkg/compiler/lib/src/js_backend/mirrors_analysis.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698