|
|
Created:
4 years ago by leonhsl(Using Gerrit) Modified:
4 years ago Reviewers:
boliu CC:
chromium-reviews, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix DisplayAndroid.java.
DisplayAndroid::stopAccurateListening() should not call
DisplayAndroidManager::startAccurateListening().
BUG=675344
Committed: https://crrev.com/9075d62cd418b457848ef6a3c51a0163eee6d068
Cr-Commit-Position: refs/heads/master@{#439338}
Patch Set 1 #
Messages
Total messages: 16 (10 generated)
The CQ bit was checked by leon.han@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
leon.han@intel.com changed reviewers: + boliu@chromium.org
Hi, would you PTAL to see whether this makes sense? Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/12/16 07:15:06, leonhsl wrote: > Hi, would you PTAL to see whether this makes sense? Thanks. oh yes, that makes sense, LGTM can you file a bug too, so that we can merge this to m56 as well
Description was changed from ========== Fix DisplayAndroid.java. DisplayAndroid::stopAccurateListening() should not call DisplayAndroidManager::startAccurateListening(). BUG= ========== to ========== Fix DisplayAndroid.java. DisplayAndroid::stopAccurateListening() should not call DisplayAndroidManager::startAccurateListening(). BUG=675344 ==========
On 2016/12/16 17:14:30, boliu wrote: > On 2016/12/16 07:15:06, leonhsl wrote: > > Hi, would you PTAL to see whether this makes sense? Thanks. > > oh yes, that makes sense, LGTM > > can you file a bug too, so that we can merge this to m56 as well Thanks! Filed bug 675344 and send this CL to CQ now.
The CQ bit was checked by leon.han@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1481970304935430, "parent_rev": "5ae43825d9b5bcd734350cd3858a8f38e4cd4b41", "commit_rev": "1625a33e55434cac56bc0881373526bc69d7bb5a"}
Message was sent while issue was closed.
Description was changed from ========== Fix DisplayAndroid.java. DisplayAndroid::stopAccurateListening() should not call DisplayAndroidManager::startAccurateListening(). BUG=675344 ========== to ========== Fix DisplayAndroid.java. DisplayAndroid::stopAccurateListening() should not call DisplayAndroidManager::startAccurateListening(). BUG=675344 Review-Url: https://codereview.chromium.org/2581113003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix DisplayAndroid.java. DisplayAndroid::stopAccurateListening() should not call DisplayAndroidManager::startAccurateListening(). BUG=675344 Review-Url: https://codereview.chromium.org/2581113003 ========== to ========== Fix DisplayAndroid.java. DisplayAndroid::stopAccurateListening() should not call DisplayAndroidManager::startAccurateListening(). BUG=675344 Committed: https://crrev.com/9075d62cd418b457848ef6a3c51a0163eee6d068 Cr-Commit-Position: refs/heads/master@{#439338} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9075d62cd418b457848ef6a3c51a0163eee6d068 Cr-Commit-Position: refs/heads/master@{#439338} |