Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2581113002: clang upload script: Skip prompt for commit message (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Reviewers:
hans, krasin1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang upload script: Skip prompt for commit message It's easy to change in the web interface, and I forgot hitting ":wq" in vim for several minutes several times now. Uploading without prompt seems like the better tradeoff to me. BUG= Committed: https://crrev.com/754d7faa36a55826bd0153979d2bfbf53006c704 Cr-Commit-Position: refs/heads/master@{#439058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/upload_revision.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Nico
wdyt?
4 years ago (2016-12-16 05:31:29 UTC) #3
krasin1
lgtm
4 years ago (2016-12-16 05:36:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581113002/1
4 years ago (2016-12-16 05:38:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 07:12:50 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-16 07:16:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/754d7faa36a55826bd0153979d2bfbf53006c704
Cr-Commit-Position: refs/heads/master@{#439058}

Powered by Google App Engine
This is Rietveld 408576698