third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp - Issue 2581083003: Initial OpenType Font Variations Support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp

Issue 2581083003: Initial OpenType Font Variations Support (Closed)

Patch Set: Fix Windows compilation by avoiding VLA Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp ('K') | « third_party/WebKit/Source/platform/fonts/WebFontDecoder.cpp ('k') | third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm » ('j') | third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp b/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp

index d6b97cd849c1b0ea916abf1f3b5612115183e958..b5328847bf7fd9f451617df60991131d5247d5b6 100644

--- a/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp

+++ b/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp

@@ -45,6 +45,12 @@ void FontPlatformData::setupPaint(SkPaint* paint,

paint->setTypeface(m_typeface);

paint->setFakeBoldText(m_syntheticBold);

paint->setTextSkewX(m_syntheticItalic ? -SK_Scalar1 / 4 : 0);

+ // TODO: Due to Skia bug 5917

eae 2016/12/16 18:48:27 TODO(drott) or TODO(layout-dev)

drott 2016/12/19 14:12:34 Done.

+ // https://bugs.chromium.org/p/skia/issues/detail?id=5917 correct advance

+ // width scaling with FreeType for font sizes under 257px currently only works

+ // with:

+ // paint->setHinting(SkPaint::kNo_Hinting);

}

} // namespace blink