third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp - Issue 2581083003: Initial OpenType Font Variations Support

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp

Issue 2581083003: Initial OpenType Font Variations Support (Closed)

Patch Set: Fix Windows compilation by avoiding VLA Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp ('K') | « third_party/WebKit/Source/platform/fonts/WebFontDecoder.cpp ('k') | third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm » ('j') | third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2006, 2007, 2008, Google Inc. All rights reserved.	2 * Copyright (c) 2006, 2007, 2008, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 27 matching lines...) Expand all Loading...
38 void FontPlatformData::setupPaint(SkPaint* paint,	38 void FontPlatformData::setupPaint(SkPaint* paint,

39 float deviceScaleFactor,	39 float deviceScaleFactor,

40 const Font*) const {	40 const Font*) const {

41 m_style.applyToPaint(*paint, deviceScaleFactor);	41 m_style.applyToPaint(*paint, deviceScaleFactor);

42	42

43 const float ts = m_textSize >= 0 ? m_textSize : 12;	43 const float ts = m_textSize >= 0 ? m_textSize : 12;

44 paint->setTextSize(SkFloatToScalar(ts));	44 paint->setTextSize(SkFloatToScalar(ts));

45 paint->setTypeface(m_typeface);	45 paint->setTypeface(m_typeface);

46 paint->setFakeBoldText(m_syntheticBold);	46 paint->setFakeBoldText(m_syntheticBold);

47 paint->setTextSkewX(m_syntheticItalic ? -SK_Scalar1 / 4 : 0);	47 paint->setTextSkewX(m_syntheticItalic ? -SK_Scalar1 / 4 : 0);

	48

	49 // TODO: Due to Skia bug 5917
	eae 2016/12/16 18:48:27 TODO(drott) or TODO(layout-dev) TODO(drott) or TODO(layout-dev) drott 2016/12/19 14:12:34 Done. Show quoted text On 2016/12/16 at 18:48:27, eae (ooo until 2017-01-03) wrote: > TODO(drott) or TODO(layout-dev) Done.
	50 // https://bugs.chromium.org/p/skia/issues/detail?id=5917 correct advance

	51 // width scaling with FreeType for font sizes under 257px currently only works

	52 // with:

	53 // paint->setHinting(SkPaint::kNo_Hinting);

48 }	54 }

49	55

50 } // namespace blink	56 } // namespace blink

OLD	NEW