[Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for 'beforeinput' (2/3)

[Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for 'beforeinput' (2/3)

This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL
https://crrev.com/2558643003)

This CL:
1. Updated calling path |Editor::undo()| =>
    |UndoStack::undo()| =>
    |EditCommandComposition::unapply()| =>
    *|EditCommandComposition::willUnapply()|.
2. Similar for redo.

* Marks new methods.

The next step is to fire 'beforeinput' in |EditCommandComposition::willUn/Reapply()|.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing

BUG=670035
Committed: https://crrev.com/c6596482a643b73b8cfe7b615639e6fea449e08b
Cr-Commit-Position: refs/heads/master@{#439640}

[chongz, 2016-12-16 22:18:38]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 22:19:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2016-12-16 22:36:35]

Description was changed from

==========
Add |EditCommandComposition::willUn/Reapply()|

BUG=670035
==========

to

==========
[Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for
'beforeinput' (1/3)

This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL

https://crrev.com/2574793002)

This CL:
1. Updated calling path |Editor::undo()| => 
    |UndoStack::undo()| => 
    |EditCommandComposition::unapply()| => 
    *|EditCommandComposition::willUnapply()|.
2. Similar for redo.

* Marks new methods.

The next step is to move 'beforeinput' logic to 
|EditCommandComposition::willUn/Reapply()|.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=670035
==========

[chongz, 2016-12-16 22:38:18]

Description was changed from

==========
[Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for
'beforeinput' (1/3)

This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL

https://crrev.com/2574793002)

This CL:
1. Updated calling path |Editor::undo()| => 
    |UndoStack::undo()| => 
    |EditCommandComposition::unapply()| => 
    *|EditCommandComposition::willUnapply()|.
2. Similar for redo.

* Marks new methods.

The next step is to move 'beforeinput' logic to 
|EditCommandComposition::willUn/Reapply()|.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=670035
==========

to

==========
[Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for
'beforeinput' (1/3)

This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL

https://crrev.com/2574793002)

This CL:
1. Updated calling path |Editor::undo()| => 
    |UndoStack::undo()| => 
    |EditCommandComposition::unapply()| => 
    *|EditCommandComposition::willUnapply()|.
2. Similar for redo.

* Marks new methods.

The next step is to fire 'beforeinput' in
|EditCommandComposition::willUn/Reapply()|.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=670035
==========

[commit-bot: I haz the power, 2016-12-17 01:11:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-17 01:11:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chongz, 2016-12-19 00:39:00]

Description was changed from

==========
[Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for
'beforeinput' (1/3)

This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL

https://crrev.com/2574793002)

This CL:
1. Updated calling path |Editor::undo()| => 
    |UndoStack::undo()| => 
    |EditCommandComposition::unapply()| => 
    *|EditCommandComposition::willUnapply()|.
2. Similar for redo.

* Marks new methods.

The next step is to fire 'beforeinput' in
|EditCommandComposition::willUn/Reapply()|.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=670035
==========

to

==========
[Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for
'beforeinput' (2/3)

This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL

https://crrev.com/2558643003)

This CL:
1. Updated calling path |Editor::undo()| => 
    |UndoStack::undo()| => 
    |EditCommandComposition::unapply()| => 
    *|EditCommandComposition::willUnapply()|.
2. Similar for redo.

* Marks new methods.

The next step is to fire 'beforeinput' in
|EditCommandComposition::willUn/Reapply()|.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=670035
==========

[chongz, 2016-12-19 00:40:32]

chongz@chromium.org changed reviewers:
+ xiaochengh@chromium.org

[chongz, 2016-12-19 00:40:33]

xiaochengh@ PTAL at this CL as well, thanks!

[Xiaocheng, 2016-12-19 03:42:59]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2016-12-19 03:43:00]

lgtm

+tkent

https://codereview.chromium.org/2581073003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
(right):

https://codereview.chromium.org/2581073003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:82: //
Fires "beforeinput". Returns |false| to cancel unapply / reapply when
Please add a "TODO: implementation" note that the two functions are not really
firing beforeinput for now.

[tkent, 2016-12-19 03:45:03]

lgtm

[chongz, 2016-12-19 19:19:11]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 19:19:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2016-12-19 20:56:24]

https://codereview.chromium.org/2581073003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
(right):

https://codereview.chromium.org/2581073003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:82: //
Fires "beforeinput". Returns |false| to cancel unapply / reapply when
On 2016/12/19 03:43:00, Xiaocheng wrote:
> Please add a "TODO: implementation" note that the two functions are not really
> firing beforeinput for now.

Done.

[commit-bot: I haz the power, 2016-12-19 21:50:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:50:18]

Dry run: This issue passed the CQ dry run.

[chongz, 2016-12-20 00:38:14]

The CQ bit was checked by chongz@chromium.org

[chongz, 2016-12-20 00:38:15]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2581073003/#ps20001
(title: "xiaocheng's review: Add TODO for implementation")

[commit-bot: I haz the power, 2016-12-20 00:38:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 00:45:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482194294649800,
"parent_rev": "0ac7a45b681921cabaa2662c27be260b5cdaaf2d", "commit_rev":
"e143cfdb83f8ccd6041cd937d3a548c20a3afb3c"}

[commit-bot: I haz the power, 2016-12-20 00:46:00]

Description was changed from

==========
[Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for
'beforeinput' (2/3)

This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL

https://crrev.com/2558643003)

This CL:
1. Updated calling path |Editor::undo()| => 
    |UndoStack::undo()| => 
    |EditCommandComposition::unapply()| => 
    *|EditCommandComposition::willUnapply()|.
2. Similar for redo.

* Marks new methods.

The next step is to fire 'beforeinput' in
|EditCommandComposition::willUn/Reapply()|.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=670035
==========

to

==========
[Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for
'beforeinput' (2/3)

This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL

https://crrev.com/2558643003)

This CL:
1. Updated calling path |Editor::undo()| => 
    |UndoStack::undo()| => 
    |EditCommandComposition::unapply()| => 
    *|EditCommandComposition::willUnapply()|.
2. Similar for redo.

* Marks new methods.

The next step is to fire 'beforeinput' in
|EditCommandComposition::willUn/Reapply()|.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=670035

Review-Url: https://codereview.chromium.org/2581073003
==========

[commit-bot: I haz the power, 2016-12-20 00:46:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 00:50:02]

Description was changed from

==========
[Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for
'beforeinput' (2/3)

This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL

https://crrev.com/2558643003)

This CL:
1. Updated calling path |Editor::undo()| => 
    |UndoStack::undo()| => 
    |EditCommandComposition::unapply()| => 
    *|EditCommandComposition::willUnapply()|.
2. Similar for redo.

* Marks new methods.

The next step is to fire 'beforeinput' in
|EditCommandComposition::willUn/Reapply()|.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=670035

Review-Url: https://codereview.chromium.org/2581073003
==========

to

==========
[Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for
'beforeinput' (2/3)

This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL
https://crrev.com/2558643003)

This CL:
1. Updated calling path |Editor::undo()| =>
    |UndoStack::undo()| =>
    |EditCommandComposition::unapply()| =>
    *|EditCommandComposition::willUnapply()|.
2. Similar for redo.

* Marks new methods.

The next step is to fire 'beforeinput' in
|EditCommandComposition::willUn/Reapply()|.

This CL shouldn't have any behavior change.

To help reviewing, here is a simple doc describing the following plans:
https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd...

BUG=670035

Committed: https://crrev.com/c6596482a643b73b8cfe7b615639e6fea449e08b
Cr-Commit-Position: refs/heads/master@{#439640}
==========

[commit-bot: I haz the power, 2016-12-20 00:50:05]

Patchset 2 (id:??) landed as
https://crrev.com/c6596482a643b73b8cfe7b615639e6fea449e08b
Cr-Commit-Position: refs/heads/master@{#439640}

[chongz, 2017-01-13 18:33:55]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2631743002/ by chongz@chromium.org.

The reason for reverting is: We want to revert all CLs and start over the
refactor process, see:
https://crbug.com/673789..