|
|
Description[Remoting Linux] Allow native messaging host to specify host config path
This CL allows caller of the me2me NMH to override the path to save the host
config, so that we can have separate host config file when testing NMH against
test gaia environment.
BUG=674685
Committed: https://crrev.com/5d768d844f27099c7fc90dc56afcc24d61344028
Cr-Commit-Position: refs/heads/master@{#438982}
Patch Set 1 #Patch Set 2 : Merge Master #
Total comments: 1
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by yuweih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Remoting Linux] Allow native messaging host to specify host config path This CL allows caller of the me2me NMH to override the path to save the host config, so that we can have separate host config file when testing NMH against test gaia environment. BUG=674685 ========== to ========== [Remoting Linux] Allow native messaging host to specify host config path This CL allows caller of the me2me NMH to override the path to save the host config, so that we can have separate host config file when testing NMH against test gaia environment. BUG=674685 ==========
yuweih@chromium.org changed reviewers: + jamiewalch@chromium.org, sergeyu@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
lgtm
The CQ bit was checked by yuweih@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jamiewalch@chromium.org Link to the patchset: https://codereview.chromium.org/2581043002/#ps20001 (title: "Merge Master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481847915623470, "parent_rev": "ede94d24cff456e88faeb435a2c008e0acac41a9", "commit_rev": "ffb09f26c09b617fa22164733fdc976906a35f31"}
Message was sent while issue was closed.
Description was changed from ========== [Remoting Linux] Allow native messaging host to specify host config path This CL allows caller of the me2me NMH to override the path to save the host config, so that we can have separate host config file when testing NMH against test gaia environment. BUG=674685 ========== to ========== [Remoting Linux] Allow native messaging host to specify host config path This CL allows caller of the me2me NMH to override the path to save the host config, so that we can have separate host config file when testing NMH against test gaia environment. BUG=674685 Review-Url: https://codereview.chromium.org/2581043002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Remoting Linux] Allow native messaging host to specify host config path This CL allows caller of the me2me NMH to override the path to save the host config, so that we can have separate host config file when testing NMH against test gaia environment. BUG=674685 Review-Url: https://codereview.chromium.org/2581043002 ========== to ========== [Remoting Linux] Allow native messaging host to specify host config path This CL allows caller of the me2me NMH to override the path to save the host config, so that we can have separate host config file when testing NMH against test gaia environment. BUG=674685 Committed: https://crrev.com/5d768d844f27099c7fc90dc56afcc24d61344028 Cr-Commit-Position: refs/heads/master@{#438982} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5d768d844f27099c7fc90dc56afcc24d61344028 Cr-Commit-Position: refs/heads/master@{#438982}
Message was sent while issue was closed.
https://codereview.chromium.org/2581043002/diff/20001/remoting/host/setup/dae... File remoting/host/setup/daemon_controller_delegate_linux.cc (right): https://codereview.chromium.org/2581043002/diff/20001/remoting/host/setup/dae... remoting/host/setup/daemon_controller_delegate_linux.cc:45: base::CommandLine* current_process = base::CommandLine::ForCurrentProcess(); This code runs in native messaging host. How are you going to pass command-line flag to native messaging host process? |