Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2581043002: [Remoting Linux] Allow native messaging host to specify host config path (Closed)

Created:
4 years ago by Yuwei
Modified:
4 years ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Linux] Allow native messaging host to specify host config path This CL allows caller of the me2me NMH to override the path to save the host config, so that we can have separate host config file when testing NMH against test gaia environment. BUG=674685 Committed: https://crrev.com/5d768d844f27099c7fc90dc56afcc24d61344028 Cr-Commit-Position: refs/heads/master@{#438982}

Patch Set 1 #

Patch Set 2 : Merge Master #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M remoting/host/setup/daemon_controller_delegate_linux.cc View 1 chunk +8 lines, -0 lines 1 comment Download

Messages

Total messages: 17 (11 generated)
Yuwei
PTAL
4 years ago (2016-12-16 00:03:15 UTC) #5
Jamie
lgtm
4 years ago (2016-12-16 00:16:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581043002/20001
4 years ago (2016-12-16 00:26:15 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 01:56:55 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5d768d844f27099c7fc90dc56afcc24d61344028 Cr-Commit-Position: refs/heads/master@{#438982}
4 years ago (2016-12-16 01:59:42 UTC) #16
Sergey Ulanov
4 years ago (2016-12-16 22:22:11 UTC) #17
Message was sent while issue was closed.
https://codereview.chromium.org/2581043002/diff/20001/remoting/host/setup/dae...
File remoting/host/setup/daemon_controller_delegate_linux.cc (right):

https://codereview.chromium.org/2581043002/diff/20001/remoting/host/setup/dae...
remoting/host/setup/daemon_controller_delegate_linux.cc:45: base::CommandLine*
current_process = base::CommandLine::ForCurrentProcess();
This code runs in native messaging host. How are you going to pass command-line
flag to native messaging host process?

Powered by Google App Engine
This is Rietveld 408576698