Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2581033002: Revert of Add Windows 10 build number to user-agent (Closed)

Created:
4 years ago by robliao
Modified:
4 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jln (very slow on Chromium), vmpstr+watch_chromium.org, scottmg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add Windows 10 build number to user-agent (patchset #1 id:1 of https://codereview.chromium.org/2533303003/ ) Reason for revert: This can cause services expecting a Windows user-agent of only two version tokens (10.0) to break. Original issue's description: > Add Windows 10 build number to user-agent > > The build number would be added to the version string in UA > only if the major version of Windows is equal or greater than 10. > Nothing would be changed for the old version of Windows. > > BUG=664622 > > Committed: https://crrev.com/bb034491431fa28ce9b2be66b17c0417dffebc13 > Cr-Commit-Position: refs/heads/master@{#437532} TBR=jochen@chromium.org,dcheng@chromium.org,pkasting@chromium.org,rbyers@chromium.org,ratsunny@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=664622, 674723 Committed: https://crrev.com/ab2b82e8113c870224036ffdb2a49a429836c76a Cr-Commit-Position: refs/heads/master@{#438996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M base/sys_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/user_agent.cc View 2 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
robliao
Created Revert of Add Windows 10 build number to user-agent
4 years ago (2016-12-15 23:56:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2581033002/1
4 years ago (2016-12-15 23:58:26 UTC) #4
dcheng
Doh. Do we know if the same thing affects Edge? Did you confirm that reverting ...
4 years ago (2016-12-16 00:52:06 UTC) #5
robliao
On 2016/12/16 00:52:06, dcheng wrote: > Doh. > > Do we know if the same ...
4 years ago (2016-12-16 00:57:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 03:11:34 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-16 03:14:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab2b82e8113c870224036ffdb2a49a429836c76a
Cr-Commit-Position: refs/heads/master@{#438996}

Powered by Google App Engine
This is Rietveld 408576698