Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2580953002:
libyuv r1637 fix Visual C implicit cast warning (Closed)
|
Created:
4 years ago by fbarchard1 Modified:
4 years ago CC:
chromium-reviews, braveyao Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionlibyuv r1637 fix Visual C implicit cast warning
ConvertFromI420 to I420 supports destination stride for subrects.
Mips MSA scaling and RGB565 conversion
Change log:
https://chromium.googlesource.com/libyuv/libyuv/+log/97fb18b8..b18fd21d
https://chromium.googlesource.com/libyuv/libyuv/+/97fb18b8..b18fd21d
BUG=libyuv:662, libyuv:660, libyuv:634
TEST=libyuv unittests pass on try bots.
Committed: https://crrev.com/9c9969289efc1d37abf00a102e7f8c97b7b099cb
Cr-Commit-Position: refs/heads/master@{#439156}
Patch Set 1 #Messages
Total messages: 23 (14 generated)
The CQ bit was checked by fbarchard@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
fbarchard@google.com changed reviewers: + kjellander@chromium.org
A cast warning fix for Visual C.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
braveyao@chromium.org changed reviewers: + braveyao@chromium.org
lgtm
Description was changed from ========== libyuv r1637 fix Visual C implicit cast warning ConvertFromI420 to I420 supports destination stride for subrects. Mips MSA scaling and RGB565 conversion Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/97fb18b8..b18fd21d https://chromium.googlesource.com/libyuv/libyuv/+/97fb18b8..b18fd21d BUG=libyuv:662,libyuv:660,libyuv:634 TEST=libyuv unittests pass on try bots. ========== to ========== libyuv r1637 fix Visual C implicit cast warning ConvertFromI420 to I420 supports destination stride for subrects. Mips MSA scaling and RGB565 conversion Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/97fb18b8..b18fd21d https://chromium.googlesource.com/libyuv/libyuv/+/97fb18b8..b18fd21d BUG=libyuv:662,libyuv:660,libyuv:634 TEST=libyuv unittests pass on try bots. ==========
fbarchard@google.com changed reviewers: + dhrosa@google.com - braveyao@chromium.org
lgtm
The CQ bit was checked by fbarchard@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by fbarchard@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481912304946490, "parent_rev":
"e163bde7497fc33a6b7525c2de0662c1b1715d1d", "commit_rev":
"41416fb997ea1cb70bbf658da619b95bb8e8c99a"}
Message was sent while issue was closed.
Description was changed from ========== libyuv r1637 fix Visual C implicit cast warning ConvertFromI420 to I420 supports destination stride for subrects. Mips MSA scaling and RGB565 conversion Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/97fb18b8..b18fd21d https://chromium.googlesource.com/libyuv/libyuv/+/97fb18b8..b18fd21d BUG=libyuv:662,libyuv:660,libyuv:634 TEST=libyuv unittests pass on try bots. ========== to ========== libyuv r1637 fix Visual C implicit cast warning ConvertFromI420 to I420 supports destination stride for subrects. Mips MSA scaling and RGB565 conversion Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/97fb18b8..b18fd21d https://chromium.googlesource.com/libyuv/libyuv/+/97fb18b8..b18fd21d BUG=libyuv:662,libyuv:660,libyuv:634 TEST=libyuv unittests pass on try bots. Review-Url: https://codereview.chromium.org/2580953002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== libyuv r1637 fix Visual C implicit cast warning ConvertFromI420 to I420 supports destination stride for subrects. Mips MSA scaling and RGB565 conversion Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/97fb18b8..b18fd21d https://chromium.googlesource.com/libyuv/libyuv/+/97fb18b8..b18fd21d BUG=libyuv:662,libyuv:660,libyuv:634 TEST=libyuv unittests pass on try bots. Review-Url: https://codereview.chromium.org/2580953002 ========== to ========== libyuv r1637 fix Visual C implicit cast warning ConvertFromI420 to I420 supports destination stride for subrects. Mips MSA scaling and RGB565 conversion Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/97fb18b8..b18fd21d https://chromium.googlesource.com/libyuv/libyuv/+/97fb18b8..b18fd21d BUG=libyuv:662,libyuv:660,libyuv:634 TEST=libyuv unittests pass on try bots. Committed: https://crrev.com/9c9969289efc1d37abf00a102e7f8c97b7b099cb Cr-Commit-Position: refs/heads/master@{#439156} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9c9969289efc1d37abf00a102e7f8c97b7b099cb Cr-Commit-Position: refs/heads/master@{#439156} |
