Issue 258093002: Revert of Limit renderer saved frames to avoid running out of fds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258093002: Revert of Limit renderer saved frames to avoid running out of fds. (Closed)

Created:
6 years, 7 months ago by Nico

Modified:
6 years, 7 months ago

Reviewers:
jbauman, piman

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Limit renderer saved frames to avoid running out of fds. (https://codereview.chromium.org/248193003/) Reason for revert: Somewhat speculative. SoftwareFrameManagerTest.DoNotEvictVisible started failing reliably on the valgrind bots after this landed. Example: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/32121/steps/memory%20test%3A%20content/logs/SoftwareFrameManagerTest.DoNotEvictVisible http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/32121/steps/memory%20test%3A%20content/logs/SoftwareFrameManagerTest.DoNotEvictVisible Original issue's description: > Limit renderer saved frames to avoid running out of fds. > > Software delegated rendering uses one fd per tile, so with a bunch of tiles that means it can run out of fds. If it seems close to hitting the limit the browser should throw away old frames to avoid this from happening. > > BUG=362603 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266383 TBR=piman@chromium.org,jbauman@chromium.org NOTREECHECKS=true NOTRY=true BUG=362603 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266582

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -52 lines)			Patch
M	content/browser/renderer_host/render_widget_host_view_aura_unittest.cc	View	4 chunks	+0 lines, -30 lines	0 comments	Download
M	content/browser/renderer_host/renderer_frame_manager.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/renderer_frame_manager.cc	View	2 chunks	+2 lines, -16 lines	0 comments	Download
M	content/common/host_shared_bitmap_manager.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Nico

Created Revert of Limit renderer saved frames to avoid running out of fds.

6 years, 7 months ago (2014-04-28 15:49:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/258093002/1

6 years, 7 months ago (2014-04-28 15:49:39 UTC) #2

Message was sent while issue was closed.

Change committed as 266582