DevTools: Rearrange Timeline toolbar for landing page mode

DevTools: Rearrange Timeline toolbar for landing page mode

BUG=570441
Committed: https://crrev.com/f19333d4891d8c0196511e6d5b7fdf6db9b07a93
Cr-Commit-Position: refs/heads/master@{#439034}

[alph, 2016-12-16 01:34:26]

alph@chromium.org changed reviewers:
+ caseq@chromium.org, pfeldman@chromium.org

[caseq, 2016-12-16 01:47:40]

https://codereview.chromium.org/2580903003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js
(right):

https://codereview.chromium.org/2580903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js:134:
UI.actionRegistry.action('main.reload').execute();
Please revert it, direct call is better when the dependency is already present.
Also, please fix the one above.

https://codereview.chromium.org/2580903003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2580903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:373:
this._recordingOptionUIControls = [];
Let's move to constructor.

https://codereview.chromium.org/2580903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:901:
this._onModeChanged();
Why is this added?

[alph, 2016-12-16 01:59:55]

https://codereview.chromium.org/2580903003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js
(right):

https://codereview.chromium.org/2580903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js:134:
UI.actionRegistry.action('main.reload').execute();
On 2016/12/16 01:47:40, caseq wrote:
> Please revert it, direct call is better when the dependency is already
present.
> Also, please fix the one above.

Reverted this one. Will address another is a separate CL.

https://codereview.chromium.org/2580903003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2580903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:373:
this._recordingOptionUIControls = [];
On 2016/12/16 01:47:40, caseq wrote:
> Let's move to constructor.

Done.

https://codereview.chromium.org/2580903003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:901:
this._onModeChanged();
On 2016/12/16 01:47:40, caseq wrote:
> Why is this added?

accidentally.

[caseq, 2016-12-16 02:08:01]

lgtm

[alph, 2016-12-16 02:10:03]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-12-16 02:11:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 05:30:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481854203446880,
"parent_rev": "570b6bcecd27755c9b2bfe2c080df92802cbfbce", "commit_rev":
"274c08db6328cd66c0887c3fe5e249f029838233"}

[commit-bot: I haz the power, 2016-12-16 05:31:07]

Description was changed from

==========
DevTools: Rearrange Timeline toolbar for landing page mode

BUG=570441
==========

to

==========
DevTools: Rearrange Timeline toolbar for landing page mode

BUG=570441

Review-Url: https://codereview.chromium.org/2580903003
==========

[commit-bot: I haz the power, 2016-12-16 05:31:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-16 05:33:42]

Description was changed from

==========
DevTools: Rearrange Timeline toolbar for landing page mode

BUG=570441

Review-Url: https://codereview.chromium.org/2580903003
==========

to

==========
DevTools: Rearrange Timeline toolbar for landing page mode

BUG=570441

Committed: https://crrev.com/f19333d4891d8c0196511e6d5b7fdf6db9b07a93
Cr-Commit-Position: refs/heads/master@{#439034}
==========

[commit-bot: I haz the power, 2016-12-16 05:33:43]

Patchset 2 (id:??) landed as
https://crrev.com/f19333d4891d8c0196511e6d5b7fdf6db9b07a93
Cr-Commit-Position: refs/heads/master@{#439034}