Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2580893002: Gate web payments iframe support on runtime enabled feature. (Closed)

Created:
4 years ago by please use gerrit instead
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews, gogerald+paymentswatch_chromium.org, haraken, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gate web payments iframe support on runtime enabled feature. OOPIF crash fix in http://crrev.com/2545693002 enabled web payments iframe support unintentionally. This patch disables it again. BUG=669585 Committed: https://crrev.com/319b249e933d384d28339f6676b8781fdc077a38 Cr-Commit-Position: refs/heads/master@{#439634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
please use gerrit instead
PTAL.
4 years ago (2016-12-15 16:43:57 UTC) #2
please use gerrit instead
Marijn, ptal in lieu of pals.
4 years ago (2016-12-19 21:17:27 UTC) #8
Marijn Kruisselbrink
lgtm
4 years ago (2016-12-19 21:44:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580893002/1
4 years ago (2016-12-19 21:46:07 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/319b249e933d384d28339f6676b8781fdc077a38 Cr-Commit-Position: refs/heads/master@{#439634}
4 years ago (2016-12-20 00:33:24 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-20 00:33:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0fdaaebc376aec248de1d2bd8fec...

Powered by Google App Engine
This is Rietveld 408576698